All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: linux-kernel@vger.kernel.org, Andrew Jones <drjones@redhat.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, xen-devel@lists.xenproject.org
Subject: Re: [PATCH] xen/x86: set panic notifier priority to minimum
Date: Tue, 13 May 2014 20:36:01 +0200	[thread overview]
Message-ID: <20140513183600.GA10992@potion.brq.redhat.com> (raw)
In-Reply-To: <537253C8.7000401@citrix.com>

2014-05-13 18:18+0100, David Vrabel:
> On 13/05/14 17:56, Radim Krčmář wrote:
> > Execution is not going to continue after telling Xen about the crash.
> > Let other panic notifiers run by postponing the final hypercall as much
> > as possible.
> 
> I can't tell how important this fix is.

Sorry, I could have put reasoning in the commit:

Not very important, depends on long linux+xen is going to last.
This patch is thinking about users/developers that would eventually find
a problem with it, and questioned our inteligence -- it makes no sense
to use the default priority for a notifier that is (can be) final.
INT_MIN is set because I don't think that Xen indended to resume domains
after crash.  (We should reason any other value as well.)

> What notifiers does this allow to be run?  How important are they?

Priority 0 (default) or lower.  Registration is stable and paravirt does
it early, so there won't be many priority 0 users before it. (None now.)

Hardware that can be passed through (most notably graphic cards), and
few debug markers (dump_kernel_offset, hung_task_panic) are affected at
the moment.

  parent reply	other threads:[~2014-05-13 18:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-13 16:56 [PATCH] xen/x86: set panic notifier priority to minimum Radim Krčmář
2014-05-13 17:18 ` David Vrabel
2014-05-13 18:36   ` Radim Krčmář
2014-05-13 18:36   ` Radim Krčmář [this message]
2014-05-13 17:18 ` David Vrabel
2014-05-15 14:56 ` David Vrabel
2014-05-15 14:56 ` David Vrabel
  -- strict thread matches above, loose matches on Subject: below --
2014-05-13 16:56 Radim Krčmář

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140513183600.GA10992@potion.brq.redhat.com \
    --to=rkrcmar@redhat.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=drjones@redhat.com \
    --cc=hpa@zytor.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.