From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: vikas.chaudhary@qlogic.com, jbottomley@parallels.com,
pjones@redhat.com, konrad@kernel.org, linux-scsi@vger.kernel.org,
giridhar.malavali@qlogic.com, iscsi-driver@qlogic.com
Subject: Re: [PATCH] iscsi_ibft: search for broadcom specific ibft sign
Date: Tue, 13 May 2014 14:54:10 -0400 [thread overview]
Message-ID: <20140513185410.GA8624@phenom.dumpdata.com> (raw)
In-Reply-To: <536A831C.4060307@cs.wisc.edu>
On Wed, May 07, 2014 at 02:01:48PM -0500, Mike Christie wrote:
> On 05/07/2014 04:00 AM, vikas.chaudhary@qlogic.com wrote:
> > From: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
> >
> > Broadcom iscsi offload firmware uses a non standard ibft sign of "BIFT".
> > This patch modifies the ibft search code to search for "BIFT" along
> > with the other possible values.
> >
> > Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
> > Acked-by: Kevin Tran <ktran@broadcom.com>
> > Acked-by: Eddie Wai <eddie.wai@broadcom.com>
> > ---
> > drivers/firmware/iscsi_ibft.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c
> > index 3ee852c..071c2c9 100644
> > --- a/drivers/firmware/iscsi_ibft.c
> > +++ b/drivers/firmware/iscsi_ibft.c
> > @@ -756,6 +756,7 @@ static const struct {
> > */
> > { ACPI_SIG_IBFT },
> > { "iBFT" },
> > + { "BIFT" }, /* Broadcom iSCSI Offload */
> > };
> >
> > static void __init acpi_find_ibft_region(void)
> >
>
> Patch looks ok to me.
>
> Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
I've converted your SoB in an Ack-by as this patch is not going
through your tree but mine.
prev parent reply other threads:[~2014-05-13 18:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 9:00 [PATCH] iscsi_ibft: search for broadcom specific ibft sign vikas.chaudhary
2014-05-07 13:47 ` Konrad Rzeszutek Wilk
2014-05-07 19:12 ` James Bottomley
2014-05-07 19:21 ` Konrad Rzeszutek Wilk
2014-05-07 19:49 ` Mike Christie
2014-05-07 20:15 ` Peter Jones
2014-05-07 20:30 ` Mike Christie
2014-05-07 20:57 ` Mike Christie
2014-05-09 11:50 ` Vikas Chaudhary
2014-05-09 13:20 ` Konrad Rzeszutek Wilk
2014-05-13 12:17 ` Vikas Chaudhary
2014-05-07 20:19 ` Giridhar Malavali
2014-05-07 19:01 ` Mike Christie
2014-05-13 18:54 ` Konrad Rzeszutek Wilk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140513185410.GA8624@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=giridhar.malavali@qlogic.com \
--cc=iscsi-driver@qlogic.com \
--cc=jbottomley@parallels.com \
--cc=konrad@kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=pjones@redhat.com \
--cc=vikas.chaudhary@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.