From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH 4/4] spi: qup: Add support for v1.1.1 Date: Tue, 13 May 2014 15:08:45 -0700 Message-ID: <20140513220845.GH20486@codeaurora.org> References: <1400016884-9568-1-git-send-email-agross@codeaurora.org> <1400016884-9568-5-git-send-email-agross@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1400016884-9568-5-git-send-email-agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andy Gross Cc: Mark Brown , linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Ivan T. Ivanov" , Bjorn Andersson List-Id: linux-arm-msm@vger.kernel.org On 05/13, Andy Gross wrote: > @@ -488,7 +491,7 @@ static int spi_qup_probe(struct platform_device *pdev) > struct resource *res; > struct device *dev; > void __iomem *base; > - u32 data, max_freq, iomode; > + u32 data = 0, max_freq, iomode; It looks like data is unused? But actually it's used to print a version out and now it will always print version 0. Perhaps that printk needs an update? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: sboyd@codeaurora.org (Stephen Boyd) Date: Tue, 13 May 2014 15:08:45 -0700 Subject: [PATCH 4/4] spi: qup: Add support for v1.1.1 In-Reply-To: <1400016884-9568-5-git-send-email-agross@codeaurora.org> References: <1400016884-9568-1-git-send-email-agross@codeaurora.org> <1400016884-9568-5-git-send-email-agross@codeaurora.org> Message-ID: <20140513220845.GH20486@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 05/13, Andy Gross wrote: > @@ -488,7 +491,7 @@ static int spi_qup_probe(struct platform_device *pdev) > struct resource *res; > struct device *dev; > void __iomem *base; > - u32 data, max_freq, iomode; > + u32 data = 0, max_freq, iomode; It looks like data is unused? But actually it's used to print a version out and now it will always print version 0. Perhaps that printk needs an update? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755476AbaEMWJA (ORCPT ); Tue, 13 May 2014 18:09:00 -0400 Received: from smtp.codeaurora.org ([198.145.11.231]:58457 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754552AbaEMWIr (ORCPT ); Tue, 13 May 2014 18:08:47 -0400 Date: Tue, 13 May 2014 15:08:45 -0700 From: Stephen Boyd To: Andy Gross Cc: Mark Brown , linux-spi@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Ivan T. Ivanov" , Bjorn Andersson Subject: Re: [PATCH 4/4] spi: qup: Add support for v1.1.1 Message-ID: <20140513220845.GH20486@codeaurora.org> References: <1400016884-9568-1-git-send-email-agross@codeaurora.org> <1400016884-9568-5-git-send-email-agross@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1400016884-9568-5-git-send-email-agross@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/13, Andy Gross wrote: > @@ -488,7 +491,7 @@ static int spi_qup_probe(struct platform_device *pdev) > struct resource *res; > struct device *dev; > void __iomem *base; > - u32 data, max_freq, iomode; > + u32 data = 0, max_freq, iomode; It looks like data is unused? But actually it's used to print a version out and now it will always print version 0. Perhaps that printk needs an update? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation