Re: [Qemu-devel] [PATCH 0/2] Accommodate VHDX images created by Disk2VHD

[Kevin Wolf <kwolf@redhat.com>]

Am 13.05.2014 um 16:00 hat Jeff Cody geschrieben:
> This series adds support for VHDX images created with Microsofts p2v tool Disk2VHD.
> 
> Jeff Cody (2):
>   block: vhdx - account for identical header sections
>   block: add test for vhdx image created by Disk2VHD
> 
>  block/vhdx.c                                            |   9 ++++++++-
>  tests/qemu-iotests/070                                  |   7 +++++++
>  tests/qemu-iotests/070.out                              |   7 +++++++
>  tests/qemu-iotests/sample_images/test-disk2vhd.vhdx.bz2 | Bin 0 -> 1424 bytes
>  4 files changed, 22 insertions(+), 1 deletion(-)
>  create mode 100644 tests/qemu-iotests/sample_images/test-disk2vhd.vhdx.bz2

Thanks, applied to the block branch.

Unrelated bug I noticed while testing this: The old error message for
opening the image was 'qemu-img: Could not open 'TEST_DIR/test-disk2vhd.
vhdx': No valid VHDX header found: Unknown error -4096'.

This is because vhdx_parse_header() doesn't set ret before jumping to
fail: while trying to find the current header.

Kevin