From: Peter Zijlstra <peterz@infradead.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>, Kevin Hilman <khilman@linaro.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Viresh Kumar <viresh.kumar@linaro.org>
Subject: Re: [PATCH 1/3] irq_work: Implement remote queueing
Date: Wed, 14 May 2014 11:10:11 +0200 [thread overview]
Message-ID: <20140514091011.GI13658@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20140514090629.GC30445@twins.programming.kicks-ass.net>
[-- Attachment #1: Type: text/plain, Size: 774 bytes --]
On Wed, May 14, 2014 at 11:06:29AM +0200, Peter Zijlstra wrote:
> > + llist_add(&work->llnode, &per_cpu(irq_work_list, cpu));
> > + native_send_call_func_single_ipi(cpu);
>
> At the very leastestest make that:
>
> if (llist_add(&work->llnode, &per_cpu(irq_work_list, cpu)))
> native_send_call_func_single_ipi(cpu);
>
> But ideally, also test the IRQ_WORK_LAZY support, its weird to have that
> only be supported for the other queue.
>
> Hmm, why do we need that LAZY crap, that completely wrecks a perfectly
> simple thing.
>
> The changelog (bc6679aef673f), not the printk() usage make much sense,
s/not/nor/
> printk() can't cause an IPI storm... printk() isn't fast enough to storm
> anything.
Except, as we all know, slow serial lines.
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-05-14 9:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 22:25 [PATCH 0/3] nohz: Move nohz kick out of scheduler IPI, v5 Frederic Weisbecker
2014-05-13 22:25 ` [PATCH 1/3] irq_work: Implement remote queueing Frederic Weisbecker
2014-05-14 9:06 ` Peter Zijlstra
2014-05-14 9:10 ` Peter Zijlstra [this message]
2014-05-14 11:38 ` Frederic Weisbecker
2014-05-14 11:54 ` Peter Zijlstra
2014-05-14 12:11 ` Frederic Weisbecker
2014-05-14 12:41 ` Peter Zijlstra
2014-05-14 13:51 ` Frederic Weisbecker
2014-05-14 13:55 ` Peter Zijlstra
2014-05-14 14:28 ` Thomas Gleixner
2014-05-13 22:25 ` [PATCH 2/3] nohz: Move full nohz kick to its own IPI Frederic Weisbecker
2014-05-13 22:25 ` [PATCH 3/3] nohz: Use IPI implicit full barrier against rq->nr_running r/w Frederic Weisbecker
2014-05-14 9:09 ` Peter Zijlstra
2014-05-14 11:38 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140514091011.GI13658@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=khilman@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.