Re: [Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039

[Kevin Wolf <kwolf@redhat.com>]

Am 14.05.2014 um 15:28 hat Fam Zheng geschrieben:
> On Wed, 05/14 15:12, Markus Armbruster wrote:
> > The shell script attempts to suppress core dumps like this:
> > 
> >     old_ulimit=$(ulimit -c)
> >     ulimit -c 0
> >     $QEMU_IO arg...
> >     ulimit -c "$old_ulimit"
> > 
> > This breaks the test hard unless the limit was zero to begin with!
> > ulimit sets both hard and soft limit by default, and (re-)raising the
> > hard limit requires privileges.  Broken since it was added in commit
> > dc68afe.
> > 
> > Could be fixed by adding -S to set only the soft limit, but I'm not
> > sure how portable that is in practice.  Simply do it in a subshell
> > instead, like this:
> > 
> >     (ulimit -c 0; exec $QEMU_IO arg...)
> > 
> > Signed-off-by: Markus Armbruster <armbru@redhat.com>
> 
> Reviewed-by: Fam Zheng <famz@redhat.com>

Thanks, applied to the block branch.

Kevin