From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/2] lib/igt_aux: Extract runtime pm helpers from pm_pc8 Date: Wed, 14 May 2014 20:34:03 +0200 Message-ID: <20140514183403.GK8790@phenom.ffwll.local> References: <1400083247-18900-1-git-send-email-daniel.vetter@ffwll.ch> <20140514175027.GA14930@strange.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id E712B6E0BF for ; Wed, 14 May 2014 11:34:07 -0700 (PDT) Received: by mail-ee0-f49.google.com with SMTP id e53so1638100eek.8 for ; Wed, 14 May 2014 11:34:06 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140514175027.GA14930@strange.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Damien Lespiau Cc: Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Wed, May 14, 2014 at 06:50:27PM +0100, Damien Lespiau wrote: > On Wed, May 14, 2014 at 06:00:46PM +0200, Daniel Vetter wrote: > > I want to use them elsewhere ... > > > > Signed-off-by: Daniel Vetter > > --- > > lib/igt_aux.c | 114 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > lib/igt_aux.h | 11 ++++++ > > tests/pm_pc8.c | 96 ++---------------------------------------------- > > 3 files changed, 128 insertions(+), 93 deletions(-) > > Just a small thing, let's not abuse _aux.c to put random stuff. How about > adding a new _pm.c? Well it's just three functions, the suspend helper is also already in there and igt_aux is fairly small. We can split once it's too big. igt_aux is very much just the bin for everything that doesn't fit anywhere else ;-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch