From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 3DB13E00724; Wed, 14 May 2014 12:01:06 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=RCVD_IN_DNSWL_HI,RDNS_NONE autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high * trust * [192.94.94.41 listed in list.dnswl.org] * 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS Received: from bear.ext.ti.com (unknown [192.94.94.41]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id F13FAE0053B for ; Wed, 14 May 2014 12:01:03 -0700 (PDT) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id s4EJ12c0025763 for ; Wed, 14 May 2014 14:01:02 -0500 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id s4EJ12sb003496 for ; Wed, 14 May 2014 14:01:02 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.3.174.1; Wed, 14 May 2014 14:01:01 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id s4EJ11FD018025; Wed, 14 May 2014 14:01:01 -0500 Date: Wed, 14 May 2014 15:01:01 -0400 From: Denys Dmytriyenko To: Hao Zhang Message-ID: <20140514190101.GQ18053@edge> References: <1400092189-13946-1-git-send-email-hzhang@ti.com> <20140514184018.GO18053@edge> <5373BCEB.9020808@ti.com> MIME-Version: 1.0 In-Reply-To: <5373BCEB.9020808@ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: meta-ti@yoctoproject.org Subject: Re: [PATCH] boot-monitor: add K2L and K2E boot monitor build support X-BeenThere: meta-ti@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-ti layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 May 2014 19:01:06 -0000 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Wed, May 14, 2014 at 02:58:51PM -0400, Hao Zhang wrote: > On 5/14/2014 2:40 PM, Denys Dmytriyenko wrote: > > On Wed, May 14, 2014 at 02:29:49PM -0400, hzhang@ti.com wrote: > >> From: Hao Zhang > >> > >> --- > >> recipes-bsp/boot-monitor/boot-monitor_git.bb | 18 +++++++++++++----- > >> 1 file changed, 13 insertions(+), 5 deletions(-) > >> > >> diff --git a/recipes-bsp/boot-monitor/boot-monitor_git.bb b/recipes-bsp/boot-monitor/boot-monitor_git.bb > >> index 7c5e9cf..2c3aa43 100644 > >> --- a/recipes-bsp/boot-monitor/boot-monitor_git.bb > >> +++ b/recipes-bsp/boot-monitor/boot-monitor_git.bb > >> @@ -3,8 +3,12 @@ EXTRA_OEMAKE = "CROSS_COMPILE=${TARGET_PREFIX}" > >> > >> LICENSE = "BSD" > >> > >> -BOOT_MONITOR_BINARY ?= "skern.bin" > >> -BOOT_MONITOR_IMAGE ?= "skern-${MACHINE}.bin" > >> +BOOT_MONITOR_BINARY_K2HK ?= "skern-k2hk.bin" > >> +BOOT_MONITOR_IMAGE_k2HK ?= "skern-k2hk-${MACHINE}.bin" > >> +BOOT_MONITOR_BINARY_K2L ?= "skern-k2l.bin" > >> +BOOT_MONITOR_IMAGE_k2L ?= "skern-k2l-${MACHINE}.bin" > >> +BOOT_MONITOR_BINARY_K2E ?= "skern-k2e.bin" > >> +BOOT_MONITOR_IMAGE_k2E ?= "skern-k2e-${MACHINE}.bin" > > > > Have you tested it? You mix case in the above variables - one has K2HK > > uppercase, another has k2HK lowercase. Same for k2l... > > > > > > Yes, I tested it. I will correct the lowercase error and re-submit the > patch. It shouldn't have worked, as you use incorrect variables below in do_deploy. > >> BOOT_MONITOR_MAKE_TARGET ?= "all" > >> > >> LIC_FILES_CHKSUM = "file://COPYING;md5=25fe219a6febf6e5bb45beda1b2eb315" > >> @@ -14,7 +18,7 @@ COMPATIBLE_MACHINE = "keystone-evm" > >> SRC_URI = "git://git.ti.com/keystone-linux/boot-monitor.git;protocol=git;branch=${BRANCH}" > >> > >> PV = "2.0" > >> -PR = "r0+gitr${SRCPV}" > >> +PR = "r1+gitr${SRCPV}" > >> > >> BRANCH = "master" > >> > >> @@ -27,7 +31,9 @@ do_compile () { > >> unset LDFLAGS > >> unset CFLAGS > >> unset CPPFLAGS > >> - oe_runmake ${BOOT_MONITOR_MAKE_TARGET} > >> + oe_runmake k2hk > >> + oe_runmake k2l > >> + oe_runmake k2e > >> } > >> > >> inherit deploy > >> @@ -36,5 +42,7 @@ addtask deploy before do_build after do_compile > >> > >> do_deploy () { > >> install -d ${DEPLOYDIR} > >> - install ${S}/${BOOT_MONITOR_BINARY} ${DEPLOYDIR}/${BOOT_MONITOR_IMAGE} > >> + install ${S}/${BOOT_MONITOR_BINARY_K2HK} ${DEPLOYDIR}/${BOOT_MONITOR_IMAGE_K2HK} > >> + install ${S}/${BOOT_MONITOR_BINARY_K2L} ${DEPLOYDIR}/${BOOT_MONITOR_IMAGE_K2L} > >> + install ${S}/${BOOT_MONITOR_BINARY_K2E} ${DEPLOYDIR}/${BOOT_MONITOR_IMAGE_K2E} > >> } > >> -- > >> 1.7.9.5 > >> > >> -- > >> _______________________________________________ > >> meta-ti mailing list > >> meta-ti@yoctoproject.org > >> https://lists.yoctoproject.org/listinfo/meta-ti >