From mboxrd@z Thu Jan 1 00:00:00 1970 From: Theodore Ts'o Subject: Re: [PATCH 2/2] fs: print a message when freezing/unfreezing filesystems Date: Wed, 14 May 2014 22:17:49 -0400 Message-ID: <20140515021749.GA3123@thunk.org> References: <1400005862-3751-1-git-send-email-mguzik@redhat.com> <1400005862-3751-2-git-send-email-mguzik@redhat.com> <20140514215457.GC5421@dastard> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Mateusz Guzik , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Josef Bacik , Jan Kara , Al Viro , Eric Sandeen To: Dave Chinner Return-path: Received: from imap.thunk.org ([74.207.234.97]:40760 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751462AbaEOCSB (ORCPT ); Wed, 14 May 2014 22:18:01 -0400 Content-Disposition: inline In-Reply-To: <20140514215457.GC5421@dastard> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, May 15, 2014 at 07:54:57AM +1000, Dave Chinner wrote: > On Tue, May 13, 2014 at 08:31:02PM +0200, Mateusz Guzik wrote: > > This helps hang troubleshooting efforts when only dmesg is available. > > I really don't think that spamming dmesg every time a filesystem is > frozen or thawed is a good idea. This happens a *lot* when systems > are using snapshots, and for the most part nobody cares about > freeze/thaw cycles because they almost always work just fine. The problems people are worried about are when there is freezing and unfreezing taking place in combination with a machine-level suspend/resume cycle, no? What if we only spammed dmesg when doing a suspend/resume? - Ted