From: "Marc Marí" <marc.mari.barcelo@gmail.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 01/16] x86: Convert conditional compilation of debug printfs to regular ifs
Date: Thu, 15 May 2014 11:56:11 +0200 [thread overview]
Message-ID: <20140515115611.62bb9cfb@crunchbang> (raw)
In-Reply-To: <53722E62.8000304@redhat.com>
El Tue, 13 May 2014 08:38:26 -0600
Eric Blake <eblake@redhat.com> escribió:
> Although __VA_ARGS__ is required by C99, the use of ##__VA_ARGS__ is a
> gcc extension; are you sure that all other supported compilers handle
> it? (I guess that's just clang)
>
> If you want something portable to C99, just use one fewer macro
> argument, so that you are guaranteed that __VA_ARGS__ will be
> non-empty (that is, subsume fmt into the ...):
>
> #define DEBUG(...) \
> QEMU_DPRINTF(DEVICE_ASSIGNMENT_DEBUG_ENABLED, \
> "pci_assign", __VA_ARGS__)
>
I found some problems to convert from ## __VA_ARGS__ to __VA_ARGS__ in
some parts, and as I asked in IRC, it was pointed that "our HACKING
document recommends the fmt, ## __VA_ARGS__ approach, and it obviously
works on all the compilers we care about". So I will leave this as it
is now.
Marc
next prev parent reply other threads:[~2014-05-15 9:56 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 7:02 [Qemu-devel] [PATCH v2 00/16] Convert conditional compilation of debug printfs Marc Marí
2014-05-13 7:02 ` [PATCH v2 01/16] x86: Convert conditional compilation of debug printfs to regular ifs Marc Marí
2014-05-13 7:02 ` Marc Marí
2014-05-13 7:02 ` [Qemu-devel] " Marc Marí
2014-05-13 7:38 ` Andreas Färber
2014-05-13 7:38 ` [Qemu-devel] " Andreas Färber
2014-05-13 14:38 ` Eric Blake
2014-05-15 9:44 ` Marc Marí
2014-05-15 9:56 ` Marc Marí [this message]
2014-05-13 15:15 ` Eric Blake
2014-05-13 15:15 ` Eric Blake
2014-05-13 7:02 ` [PATCH v2 02/16] s390: " Marc Marí
2014-05-13 7:02 ` [Qemu-devel] " Marc Marí
2014-05-13 9:04 ` Cornelia Huck
2014-05-13 9:04 ` Cornelia Huck
2014-05-13 14:45 ` Eric Blake
2014-05-13 14:45 ` [Qemu-devel] " Eric Blake
2014-05-13 7:02 ` [Qemu-devel] [PATCH v2 03/16] scsi: " Marc Marí
2014-05-13 7:02 ` [Qemu-devel] [PATCH v2 04/16] highbank: " Marc Marí
2014-05-13 10:06 ` Marc Marí
2014-05-13 7:02 ` [Qemu-devel] [PATCH v2 05/16] xilinx: " Marc Marí
2014-05-13 9:59 ` Marc Marí
2014-05-13 7:02 ` [Qemu-devel] [PATCH v2 06/16] spapr: " Marc Marí
2014-05-13 7:18 ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
2014-05-13 7:02 ` [Qemu-devel] [PATCH v2 07/16] stellaris: " Marc Marí
2014-05-13 15:05 ` Eric Blake
2014-05-13 7:02 ` [Qemu-devel] [PATCH v2 08/16] tpm: " Marc Marí
2014-05-13 9:39 ` Marc Marí
2014-05-13 7:02 ` [Qemu-devel] [PATCH v2 09/16] i82374: " Marc Marí
2014-05-13 9:20 ` Marc Marí
2014-05-13 7:02 ` [Qemu-devel] [PATCH v2 10/16] i8257: " Marc Marí
2014-05-13 7:02 ` [Qemu-devel] [PATCH v2 11/16] rc4030: " Marc Marí
2014-05-13 9:16 ` Marc Marí
2014-05-13 7:02 ` [Qemu-devel] [PATCH v2 12/16] sd: " Marc Marí
2014-05-13 7:02 ` [Qemu-devel] [PATCH v2 13/16] isa: " Marc Marí
2014-05-13 7:02 ` [Qemu-devel] [PATCH v2 14/16] lan9118: " Marc Marí
2014-05-13 7:02 ` [Qemu-devel] [PATCH v2 15/16] pci-host: " Marc Marí
2014-05-13 9:13 ` Marc Marí
2014-05-13 7:02 ` [Qemu-devel] [PATCH v2 16/16] common: " Marc Marí
2014-05-13 9:05 ` Cornelia Huck
2014-05-13 15:21 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140515115611.62bb9cfb@crunchbang \
--to=marc.mari.barcelo@gmail.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.