Re: [PATCH iproute2] tc/netem: loss gemodel options fixes

[Stephen Hemminger <stephen@networkplumber.org>]

On Sat, 10 May 2014 13:34:58 -0700
Jay Vosburgh <jay.vosburgh@canonical.com> wrote:

> 
> 	First, the default value for 1-k is documented as being 0, but is
> currently being set to 1. (100%).  This causes all packets to be dropped
> in the good state if 1-k is not explicitly specified.  Fix this by setting
> the default to 0.
> 
> 	Second, the 1-h option is parsed correctly, however, the kernel is
> expecting "h", not 1-h.  Fix this by inverting the "1-h" percentage before
> sending to and after receiving from the kernel.  This does change the
> behavior, but makes it consistent with the netem documentation and the
> literature on the Gilbert-Elliot model, which refer to "1-h" and "1-k,"
> not "h" or "k" directly.
> 
> 	Last, fix a minor formatting issue for the options reporting.
> 
> Signed-off-by: Jay Vosburgh <jay.vosburgh@canonical.com>

Could you get review of original author of this loss model?
  Stefano Salsano <stefano.salsano@uniroma2.it>