From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754168AbaEOQKc (ORCPT ); Thu, 15 May 2014 12:10:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21098 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751653AbaEOQKa (ORCPT ); Thu, 15 May 2014 12:10:30 -0400 Date: Thu, 15 May 2014 18:09:51 +0200 From: Mateusz Guzik To: Dave Jones , Peter Zijlstra , Oleg Nesterov , Thomas Gleixner , linux-kernel@vger.kernel.org Subject: Re: WARN in do_rt_tgsigqueueinfo() Message-ID: <20140515160950.GA22846@mguzik.redhat.com> References: <20140515133834.GN13658@twins.programming.kicks-ass.net> <20140515142723.GB22041@mguzik.redhat.com> <20140515150412.GP30445@twins.programming.kicks-ass.net> <20140515155415.GA326@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20140515155415.GA326@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 15, 2014 at 11:54:15AM -0400, Dave Jones wrote: > On Thu, May 15, 2014 at 05:04:12PM +0200, Peter Zijlstra wrote: > > > > > trinity$ MALLOC_CHECK_=0 ./trinity -xinit_module -xreboot -xshutdown -xunshare -xnfsservctl -xclock_nanosleep -xuselib -xumount -xmount -m --quiet -C 400 -l off -xmremap > > > > > > > > [watchdog] kernel became tainted! (512/0) Last seed was 4072360471 > > > > > > > > [15908.562512] ------------[ cut here ]------------ > > > > [15908.567245] WARNING: CPU: 22 PID: 3312 at /usr/src/linux-2.6/kernel/signal.c:3060 do_rt_tgsigqueueinfo+0xb4/0xc0() > > > > > > > > This is apparently a very common thing to hit according to google. > > > > > > Well, it warns about an argument received from userland, so nothing fishy > > > going on as far as kernel consistency is concerned if that's what you mean. > > > > I hadn't looked that far.. I just manged to hit it two times in a row > > while waiting for my bug to trigger. > > There's a ton of 'noise' like this that fuzzing turns up. > I've been collecting some of the stuff to shut it up.. > > http://codemonkey.org.uk/junk/silence-fuzz-testing-noise.patch > http://codemonkey.org.uk/junk/silence-noisy-deprecated-warnings-while-fuzzing.patch > > I'm of the opinion that a user-triggerable WARN is a bug, but aparently > not everyone else feels that way. > imho warning sysadmins about userspace using deprecated stuff is fine as long as users are not able to spam the console with it. Warning reported here just looks scary and provides no information for sysadmins so I guess it hould be changed. I see no value in removing this stuff. If it shows up in production you most likely want to know. Filtering this out during fuzzing should be an issue. my $0,03 -- Mateusz Guzik