All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Namhyung Kim <namhyung@gmail.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	acme@infradead.org, linux-kernel@vger.kernel.org,
	peterz@infradead.org, eranian@google.com, jolsa@redhat.com,
	Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 3/9] perf, tools: Add support for reading JSON event files
Date: Thu, 15 May 2014 22:18:38 +0200	[thread overview]
Message-ID: <20140515201838.GE1873@two.firstfloor.org> (raw)
In-Reply-To: <874n0tlzcl.fsf@sejong.aot.lge.com>

> And more generally, can we extend these if-else's to a generic loop to
> check a table like in match_field() so that it can be added easily?

The simple cases are all already handled in a table above.

The if() only contains cases that need special code. I don't think
callbacks would be better here.

-Andi

  reply	other threads:[~2014-05-15 20:18 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-12 22:51 perf: Add support for full Intel event lists v3 Andi Kleen
2014-05-12 22:51 ` [PATCH 1/9] perf, tools: Add jsmn `jasmine' JSON parser Andi Kleen
2014-05-14  3:25   ` Namhyung Kim
2014-05-14  5:00     ` Andi Kleen
2014-05-12 22:51 ` [PATCH 2/9] perf, tools: Add support for text descriptions of events and alias add Andi Kleen
2014-05-12 22:51 ` [PATCH 3/9] perf, tools: Add support for reading JSON event files Andi Kleen
2014-05-14  5:10   ` Namhyung Kim
2014-05-15 20:18     ` Andi Kleen [this message]
2014-05-12 22:51 ` [PATCH 4/9] perf, tools: Automatically look for event file name for cpu v2 Andi Kleen
2014-05-12 22:51 ` [PATCH 5/9] perf, tools: Add perf download to download event files v2 Andi Kleen
2014-05-14  5:17   ` Namhyung Kim
2014-05-15 20:10     ` Andi Kleen
2014-05-12 22:51 ` [PATCH 6/9] perf, tools: Allow events with dot Andi Kleen
2014-05-12 22:51 ` [PATCH 7/9] perf, tools: Query terminal width and use in perf list Andi Kleen
2014-05-12 22:51 ` [PATCH 8/9] perf, tools, test: Add test case for alias and JSON parsing Andi Kleen
2014-05-14  5:27   ` Namhyung Kim
2014-05-12 22:51 ` [PATCH 9/9] perf, tools, record: Always allow to overide default period v2 Andi Kleen
2014-05-14  5:50   ` Namhyung Kim
2014-05-15 20:51     ` Andi Kleen
2014-05-15 16:09 ` perf: Add support for full Intel event lists v3 Hagen Paul Pfeifer
2014-05-15 19:12   ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140515201838.GE1873@two.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=acme@infradead.org \
    --cc=ak@linux.intel.com \
    --cc=eranian@google.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@gmail.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.