All of lore.kernel.org
 help / color / mirror / Atom feed
From: Don Zickus <dzickus@redhat.com>
To: x86@kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>,
	Andi Kleen <andi@firstfloor.org>,
	gong.chen@linux.intel.com, LKML <linux-kernel@vger.kernel.org>,
	Elliott@hp.com
Subject: Re: [PATCH 0/6 V2] x86, nmi: Various fixes and cleanups
Date: Thu, 15 May 2014 16:28:48 -0400	[thread overview]
Message-ID: <20140515202848.GJ50500@redhat.com> (raw)
In-Reply-To: <1400181949-157170-1-git-send-email-dzickus@redhat.com>

On Thu, May 15, 2014 at 03:25:43PM -0400, Don Zickus wrote:
> I started this patch by fixing a performance problem with the GHES
> NMI handler and then things evolved to more patches as I was poking
> around in the code.
> 
> The main focus was moving the GHES NMI driver to its own NMI subtype
> to avoid slowing down perf handling.  Then I decided to move the
> default external NMI handler to its own routine.  Then finally, I
> needed to see which NMI handlers were registered so I hacked up
> /proc/interrupts to show me.
> 
> Tested mostly on HP boxes that have GHES enabled and having the iLO
> send NMIs to panic the box (using hpwdt driver).  Ran perf on other
> GHES enabled boxes to test performance results.
> 
> V2: adding irq_work items to handled possible lost NMIs (new patch 1)
>     modified output of /proc/interrupts based on feedback (patch 6)
> 

ugh.  Forgot to snip below..
> Don Zickus (5):
>   x86, nmi:  Add new nmi type 'external'
>   x86, nmi: Add boot line option 'panic_on_unrecovered_nmi' and
>     'panic_on_io_nmi'
>   x86, nmi: Remove 'reason' value from unknown nmi output
>   x86, nmi: Move default external NMI handler to its own routine
>   x86, nmi: Add better NMI stats to /proc/interrupts and show handlers
> 
>  Documentation/kernel-parameters.txt |    9 ++
>  arch/x86/include/asm/nmi.h          |    5 +
>  arch/x86/kernel/irq.c               |    3 +
>  arch/x86/kernel/nmi.c               |  199 ++++++++++++++++++++++++++--------
>  drivers/acpi/apei/ghes.c            |    4 +-
>  drivers/watchdog/hpwdt.c            |   24 +++--
>  6 files changed, 187 insertions(+), 57 deletions(-)
> 
> *** BLURB HERE ***

.. to here.

Cheers,
Don

> 
> Don Zickus (6):
>   x86, nmi:  Implement delayed irq_work mechanism to handle lost NMIs
>   x86, nmi:  Add new nmi type 'external'
>   x86, nmi: Add boot line option 'panic_on_unrecovered_nmi' and
>     'panic_on_io_nmi'
>   x86, nmi: Remove 'reason' value from unknown nmi output
>   x86, nmi: Move default external NMI handler to its own routine
>   x86, nmi: Add better NMI stats to /proc/interrupts and show handlers
> 
>  Documentation/kernel-parameters.txt |    9 +
>  arch/x86/include/asm/nmi.h          |    5 +
>  arch/x86/kernel/irq.c               |    3 +
>  arch/x86/kernel/nmi.c               |  302 +++++++++++++++++++++++++++++-----
>  drivers/acpi/apei/ghes.c            |    4 +-
>  drivers/watchdog/hpwdt.c            |   24 ++-
>  6 files changed, 292 insertions(+), 55 deletions(-)
> 

      parent reply	other threads:[~2014-05-15 20:29 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-15 19:25 [PATCH 0/6 V2] x86, nmi: Various fixes and cleanups Don Zickus
2014-05-15 19:25 ` [PATCH 1/6] x86, nmi: Implement delayed irq_work mechanism to handle lost NMIs Don Zickus
2014-05-21 10:29   ` Peter Zijlstra
2014-05-21 16:45     ` Don Zickus
2014-05-21 17:51       ` Peter Zijlstra
2014-05-21 19:02         ` Don Zickus
2014-05-21 19:38           ` Peter Zijlstra
2014-05-15 19:25 ` [PATCH 2/6] x86, nmi: Add new nmi type 'external' Don Zickus
2014-05-15 19:25 ` [PATCH 3/6] x86, nmi: Add boot line option 'panic_on_unrecovered_nmi' and 'panic_on_io_nmi' Don Zickus
2014-05-15 19:25 ` [PATCH 4/6] x86, nmi: Remove 'reason' value from unknown nmi output Don Zickus
2014-05-15 19:25 ` [PATCH 5/6] x86, nmi: Move default external NMI handler to its own routine Don Zickus
2014-05-21 10:38   ` Peter Zijlstra
2014-05-21 16:48     ` Don Zickus
2014-05-21 18:17       ` Peter Zijlstra
2014-05-21 19:13         ` Don Zickus
2014-05-15 19:25 ` [PATCH 6/6 V2] x86, nmi: Add better NMI stats to /proc/interrupts and show handlers Don Zickus
2014-05-15 20:28 ` Don Zickus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140515202848.GJ50500@redhat.com \
    --to=dzickus@redhat.com \
    --cc=Elliott@hp.com \
    --cc=andi@firstfloor.org \
    --cc=gong.chen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.