From: Greg KH <gregkh@linuxfoundation.org>
To: Paul McQuade <paulmcquad@gmail.com>
Cc: devel@driverdev.osuosl.org,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging:dgnc:dgnc_driver open/close braces
Date: Thu, 15 May 2014 13:34:54 -0700 [thread overview]
Message-ID: <20140515203454.GA14523@kroah.com> (raw)
In-Reply-To: <1397061004-7924-1-git-send-email-paulmcquad@gmail.com>
On Wed, Apr 09, 2014 at 05:30:04PM +0100, Paul McQuade wrote:
> ERROR: that open brace { should be on the previous line
> ERROR: else should follow close brace '}
> ERROR: space required before the open parenthesis '(
> ERROR: trailing whitespace
> ERROR: open brace '{' following function declarations go on the next line
> ERROR: space required after that ',' (ctx:VxV)
> ERROR: space required before the open parenthesis '('
>
> Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
> ---
> drivers/staging/dgnc/dgnc_driver.c | 22 ++++++++++------------
> 1 file changed, 10 insertions(+), 12 deletions(-)
There is something really odd in this patch that git refuses to apply
it. Can you please refresh it and send it again, after verifying that
it will apply properly on your side?
The error I get is:
Applying: Staging:dgnc:dgnc_driver open/close braces
fatal: patch fragment without header at line 77: @@ -895,7 +893,7 @@ int dgnc_ms_sleep(ulong ms)
thanks,
greg k-h
prev parent reply other threads:[~2014-05-15 20:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 16:30 [PATCH] Staging:dgnc:dgnc_driver open/close braces Paul McQuade
2014-05-15 20:34 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140515203454.GA14523@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmcquad@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.