All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] lsof: don't use host toolchain to determine target libc
Date: Thu, 15 May 2014 23:23:55 +0200	[thread overview]
Message-ID: <20140515212355.GE3463@free.fr> (raw)
In-Reply-To: <106644d5ef8b1b8a9cfeba005079957f63702757.1400071508.git.baruch@tkos.co.il>

Baruch, All,

On 2014-05-14 15:45 +0300, Baruch Siach spake thusly:
> The lsof Configure script builds a test program using the host toolchain to
> test whether glibc is used. This test is broken in cross compilation
> environment. Set LINUX_CLIB to avoid the test. This should give the correct
> result even for non glibc toolchains, since all libc variants we support have
> the netinet/tcp.h header.
> 
> Fixes:
> http://autobuild.buildroot.net/results/a1f/a1f0572dbf968c21f70b35cefff7ef7a1d9a348a/
> 
> Cc: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/lsof/lsof.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/lsof/lsof.mk b/package/lsof/lsof.mk
> index f4b1b4cb8f86..332d1f83a5df 100644
> --- a/package/lsof/lsof.mk
> +++ b/package/lsof/lsof.mk
> @@ -49,7 +49,8 @@ endef
>  define LSOF_CONFIGURE_CMDS
>  	(cd $(@D) ; \
>  		echo n | $(TARGET_CONFIGURE_OPTS) DEBUG="$(TARGET_CFLAGS) $(BR2_LSOF_CFLAGS)" \
> -		LSOF_INCLUDE="$(STAGING_DIR)/usr/include" LSOF_CFLAGS_OVERRIDE=1 ./Configure linux)
> +		LSOF_INCLUDE="$(STAGING_DIR)/usr/include" LSOF_CFLAGS_OVERRIDE=1 \
> +		LINUX_CLIB=-DGLIBCV=2 ./Configure linux)
>  	$(LSOF_CONFIGURE_WCHAR_FIXUPS)
>  	$(LSOF_CONFIGURE_LOCALE_FIXUPS)
>  endef
> -- 
> 2.0.0.rc0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-05-15 21:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-14 12:45 [Buildroot] [PATCH] lsof: don't use host toolchain to determine target libc Baruch Siach
2014-05-15 21:23 ` Yann E. MORIN [this message]
2014-05-15 21:39 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140515212355.GE3463@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.