* [PATCH] staging: sep: fix coding style issue
@ 2014-05-06 17:54 Clément Calmels
2014-05-15 22:05 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Clément Calmels @ 2014-05-06 17:54 UTC (permalink / raw)
To: devel, linux-kernel
This is a patch to fix coding style issue found by
scripts/checkpatch.pl utility.
Signed-off-by: Clément Calmels <clement.calmels@free.fr>
---
drivers/staging/sep/sep_dev.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/sep/sep_dev.h b/drivers/staging/sep/sep_dev.h
index 5f6a07f..5faeefa1 100644
--- a/drivers/staging/sep/sep_dev.h
+++ b/drivers/staging/sep/sep_dev.h
@@ -139,12 +139,14 @@ struct sep_queue_info {
static inline void sep_write_reg(struct sep_device *dev, int reg, u32 value)
{
void __iomem *addr = dev->reg_addr + reg;
+
writel(value, addr);
}
static inline u32 sep_read_reg(struct sep_device *dev, int reg)
{
void __iomem *addr = dev->reg_addr + reg;
+
return readl(addr);
}
@@ -152,6 +154,7 @@ static inline u32 sep_read_reg(struct sep_device *dev, int reg)
static inline void sep_wait_sram_write(struct sep_device *dev)
{
u32 reg_val;
+
do {
reg_val = sep_read_reg(dev, HW_SRAM_DATA_READY_REG_ADDR);
} while (!(reg_val & 1));
--
2.0.0.rc0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: sep: fix coding style issue
2014-05-06 17:54 [PATCH] staging: sep: fix coding style issue Clément Calmels
@ 2014-05-15 22:05 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2014-05-15 22:05 UTC (permalink / raw)
To: Clément Calmels; +Cc: devel, linux-kernel
On Tue, May 06, 2014 at 07:54:41PM +0200, Clément Calmels wrote:
> This is a patch to fix coding style issue found by
> scripts/checkpatch.pl utility.
>
> Signed-off-by: Clément Calmels <clement.calmels@free.fr>
> ---
> drivers/staging/sep/sep_dev.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/staging/sep/sep_dev.h b/drivers/staging/sep/sep_dev.h
> index 5f6a07f..5faeefa1 100644
> --- a/drivers/staging/sep/sep_dev.h
> +++ b/drivers/staging/sep/sep_dev.h
> @@ -139,12 +139,14 @@ struct sep_queue_info {
> static inline void sep_write_reg(struct sep_device *dev, int reg, u32 value)
> {
> void __iomem *addr = dev->reg_addr + reg;
> +
> writel(value, addr);
> }
>
> static inline u32 sep_read_reg(struct sep_device *dev, int reg)
> {
> void __iomem *addr = dev->reg_addr + reg;
> +
> return readl(addr);
> }
>
> @@ -152,6 +154,7 @@ static inline u32 sep_read_reg(struct sep_device *dev, int reg)
> static inline void sep_wait_sram_write(struct sep_device *dev)
> {
> u32 reg_val;
> +
> do {
> reg_val = sep_read_reg(dev, HW_SRAM_DATA_READY_REG_ADDR);
> } while (!(reg_val & 1));
Someone else already sent in this same patch, sorry.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-15 22:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-06 17:54 [PATCH] staging: sep: fix coding style issue Clément Calmels
2014-05-15 22:05 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.