From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Omar Ramirez Luna <omar.ramirez@copitl.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Masood Mehmood <ody.guru@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix for possible null pointer dereference in node.c
Date: Fri, 16 May 2014 01:43:27 +0300 [thread overview]
Message-ID: <20140515224327.GA16255@mwanda> (raw)
In-Reply-To: <1400190833-27882-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On Thu, May 15, 2014 at 11:53:53PM +0200, Rickard Strandqvist wrote:
> There is otherwise a risk of a possible null pointer dereference.
>
None of the callers pass in a NULL hnode so there isn't actually a NULL
dereference here. You could just remove the check.
regards,
dan carpenter
next prev parent reply other threads:[~2014-05-15 22:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 21:53 [PATCH] Fix for possible null pointer dereference in node.c Rickard Strandqvist
2014-05-15 22:08 ` Greg Kroah-Hartman
2014-05-15 22:14 ` Rickard Strandqvist
2014-05-15 22:43 ` Dan Carpenter [this message]
2014-05-17 13:21 ` Rickard Strandqvist
2014-05-17 18:56 ` Dan Carpenter
2014-05-18 15:49 ` Rickard Strandqvist
2014-05-18 16:22 ` Dan Carpenter
2014-05-18 17:14 ` Rickard Strandqvist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140515224327.GA16255@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ody.guru@gmail.com \
--cc=omar.ramirez@copitl.com \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.