From: Daniel Vetter <daniel@ffwll.ch>
To: "O'Rourke, Tom" <Tom.O'Rourke@intel.com>
Cc: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Widawsky, Benjamin" <benjamin.widawsky@intel.com>
Subject: Re: [PATCH 2/5] drm/i915/bdw: Implement a basic PM interrupt handler
Date: Fri, 16 May 2014 11:09:35 +0200 [thread overview]
Message-ID: <20140516090935.GE8790@phenom.ffwll.local> (raw)
In-Reply-To: <411E5DC12A51ED4CB1159E14310E532B9D8A72C3@FMSMSX119.amr.corp.intel.com>
On Fri, May 16, 2014 at 01:38:18AM +0000, O'Rourke, Tom wrote:
> >+static void gen8_disable_rps_interrupts(struct drm_device *dev) {
> >+ struct drm_i915_private *dev_priv = dev->dev_private;
> >+
> >+ I915_WRITE(GEN6_PMINTRMSK, 0xffffffff);
>
> [TOR:] Please note that for Broadwell, bit 31 in GEN6_PMINTRMSK is not an interrupt disable bit.
> In "drm/i915: Enable PM Interrupts target via Display Interface." this bit is defined as:
> +#define GEN8_PMINTR_REDIRECT_TO_NON_DISP (1<<31)
>
> Writing this bit here could have unintended consequences.
Hm, we seem to unconditionally set this bit on gen8 anyway. Still harmful?
Mika, Ville?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-05-16 9:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 17:58 [PATCH 1/5] drm/i915: Bail out early on gen6_signal if no semaphores Mika Kuoppala
2014-05-15 17:58 ` [PATCH 2/5] drm/i915/bdw: Implement a basic PM interrupt handler Mika Kuoppala
2014-05-16 1:38 ` O'Rourke, Tom
2014-05-16 9:09 ` Daniel Vetter [this message]
2014-05-16 9:46 ` Ville Syrjälä
2014-05-16 10:09 ` Daniel Vetter
2014-05-16 10:44 ` [PATCH] drm/i915: Be careful with non-disp bit in PMINTRMSK Mika Kuoppala
2014-05-16 14:29 ` Daniel Vetter
2014-05-15 17:58 ` [PATCH 3/5] drm/i915: Enable PM Interrupts target via Display Interface Mika Kuoppala
2014-05-15 17:58 ` [PATCH 4/5] drm/i915: Fix rc6 options debug info Mika Kuoppala
2014-05-15 17:58 ` [PATCH 5/5] drm/i915: Enable rc6 with bdw Mika Kuoppala
2014-05-15 21:17 ` Daniel Vetter
2014-05-15 18:38 ` [PATCH 1/5] drm/i915: Bail out early on gen6_signal if no semaphores Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140516090935.GE8790@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Tom.O'Rourke@intel.com \
--cc=benjamin.widawsky@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.