From: Denys Dmytriyenko <denys@ti.com>
To: <hzhang@ti.com>
Cc: meta-ti@yoctoproject.org
Subject: Re: [PATCH 3/3] keystone: k2e-evm config: add k2e-evm machine config
Date: Fri, 16 May 2014 15:31:19 -0400 [thread overview]
Message-ID: <20140516193118.GJ18053@edge> (raw)
In-Reply-To: <1400268148-24770-1-git-send-email-hzhang@ti.com>
On Fri, May 16, 2014 at 03:22:28PM -0400, hzhang@ti.com wrote:
> From: Hao Zhang <hzhang@ti.com>
>
> Add a new k2e-evm machine config for Keystone II SoC family.
>
> Signed-off-by: Hao Zhang <hzhang@ti.com>
> ---
> conf/machine/{k2hk-evm.conf => k2e-evm.conf} | 8 ++++----
> recipes-bsp/boot-monitor/boot-monitor_git.bb | 2 +-
> 2 files changed, 5 insertions(+), 5 deletions(-)
> copy conf/machine/{k2hk-evm.conf => k2e-evm.conf} (79%)
Ok, this one is much better to review! Not sure why #2 wasn't done like this.
I mostly like it. Still the same comment about COMPATIBLE_MACHINE below for
the boot-monitor.
> diff --git a/conf/machine/k2hk-evm.conf b/conf/machine/k2e-evm.conf
> similarity index 79%
> copy from conf/machine/k2hk-evm.conf
> copy to conf/machine/k2e-evm.conf
> index 2885335..551587f 100644
> --- a/conf/machine/k2hk-evm.conf
> +++ b/conf/machine/k2e-evm.conf
> @@ -1,12 +1,12 @@
> #@TYPE: Machine
> -#@NAME: Keystone 2 machine
> -#@DESCRIPTION: Machine configuration for the TI Keystone 2
> +#@NAME: Keystone 2 K2E machine
> +#@DESCRIPTION: Machine configuration for the TI Keystone 2 K2E EVM
>
> require conf/machine/include/keystone.inc
>
> -UBOOT_MACHINE = "k2hk_evm_config"
> +UBOOT_MACHINE = "k2e_evm_config"
>
> -BOOT_MONITOR_MAKE_TARGET = "k2hk"
> +BOOT_MONITOR_MAKE_TARGET = "k2e"
>
> IMAGE_FSTYPES += "ubi tar.gz cpio"
>
> diff --git a/recipes-bsp/boot-monitor/boot-monitor_git.bb b/recipes-bsp/boot-monitor/boot-monitor_git.bb
> index 0761d83..b3aa806 100644
> --- a/recipes-bsp/boot-monitor/boot-monitor_git.bb
> +++ b/recipes-bsp/boot-monitor/boot-monitor_git.bb
> @@ -8,7 +8,7 @@ BOOT_MONITOR_IMAGE ?= "skern-${MACHINE}.bin"
>
> LIC_FILES_CHKSUM = "file://COPYING;md5=25fe219a6febf6e5bb45beda1b2eb315"
>
> -COMPATIBLE_MACHINE = "k2hk-evm|k2l-evm"
> +COMPATIBLE_MACHINE = "k2hk-evm|k2l-evm|k2e-evm"
Why can't use use the SOC family here:
COMPATIBLE_MACHINE = "keystone"
> SRC_URI = "git://git.ti.com/keystone-linux/boot-monitor.git;protocol=git;branch=${BRANCH}"
>
> --
> 1.7.9.5
>
> --
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti
next prev parent reply other threads:[~2014-05-16 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 19:22 [PATCH 3/3] keystone: k2e-evm config: add k2e-evm machine config hzhang
2014-05-16 19:31 ` Denys Dmytriyenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-05-16 19:14 hzhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140516193118.GJ18053@edge \
--to=denys@ti.com \
--cc=hzhang@ti.com \
--cc=meta-ti@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.