From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Minchan Kim <minchan@kernel.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Dave Hansen <dave.hansen@intel.com>,
John Stultz <john.stultz@linaro.org>,
Zhang Yanfei <zhangyanfei@cn.fujitsu.com>,
Hugh Dickins <hughd@google.com>, Rik van Riel <riel@redhat.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Mel Gorman <mgorman@suse.de>, Jason Evans <je@fb.com>
Subject: Re: [PATCH v6] mm: support madvise(MADV_FREE)
Date: Fri, 16 May 2014 22:38:00 +0300 [thread overview]
Message-ID: <20140516193800.GA7273@node.dhcp.inet.fi> (raw)
In-Reply-To: <20140516063427.GC27599@bbox>
On Fri, May 16, 2014 at 03:34:27PM +0900, Minchan Kim wrote:
> > > +static inline unsigned long lazyfree_pmd_range(struct mmu_gather *tlb,
> > > + struct vm_area_struct *vma, pud_t *pud,
> > > + unsigned long addr, unsigned long end)
> > > +{
> > > + pmd_t *pmd;
> > > + unsigned long next;
> > > +
> > > + pmd = pmd_offset(pud, addr);
> > > + do {
> > > + next = pmd_addr_end(addr, end);
> > > + if (pmd_trans_huge(*pmd))
> > > + split_huge_page_pmd(vma, addr, pmd);
> >
> > /* XXX */ as well? :)
>
> You meant huge page unit lazyfree rather than 4K page unit?
> If so, I will add.
Please, free huge page if range cover it.
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Minchan Kim <minchan@kernel.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Dave Hansen <dave.hansen@intel.com>,
John Stultz <john.stultz@linaro.org>,
Zhang Yanfei <zhangyanfei@cn.fujitsu.com>,
Hugh Dickins <hughd@google.com>, Rik van Riel <riel@redhat.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Mel Gorman <mgorman@suse.de>, Jason Evans <je@fb.com>
Subject: Re: [PATCH v6] mm: support madvise(MADV_FREE)
Date: Fri, 16 May 2014 22:38:00 +0300 [thread overview]
Message-ID: <20140516193800.GA7273@node.dhcp.inet.fi> (raw)
In-Reply-To: <20140516063427.GC27599@bbox>
On Fri, May 16, 2014 at 03:34:27PM +0900, Minchan Kim wrote:
> > > +static inline unsigned long lazyfree_pmd_range(struct mmu_gather *tlb,
> > > + struct vm_area_struct *vma, pud_t *pud,
> > > + unsigned long addr, unsigned long end)
> > > +{
> > > + pmd_t *pmd;
> > > + unsigned long next;
> > > +
> > > + pmd = pmd_offset(pud, addr);
> > > + do {
> > > + next = pmd_addr_end(addr, end);
> > > + if (pmd_trans_huge(*pmd))
> > > + split_huge_page_pmd(vma, addr, pmd);
> >
> > /* XXX */ as well? :)
>
> You meant huge page unit lazyfree rather than 4K page unit?
> If so, I will add.
Please, free huge page if range cover it.
--
Kirill A. Shutemov
next prev parent reply other threads:[~2014-05-16 19:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 1:26 [PATCH v6] mm: support madvise(MADV_FREE) Minchan Kim
2014-05-12 1:26 ` Minchan Kim
2014-05-15 15:46 ` Johannes Weiner
2014-05-15 15:46 ` Johannes Weiner
2014-05-15 16:07 ` Rik van Riel
2014-05-15 16:07 ` Rik van Riel
2014-05-16 6:34 ` Minchan Kim
2014-05-16 6:34 ` Minchan Kim
2014-05-16 19:38 ` Kirill A. Shutemov [this message]
2014-05-16 19:38 ` Kirill A. Shutemov
2014-05-19 3:24 ` Minchan Kim
2014-05-19 3:24 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140516193800.GA7273@node.dhcp.inet.fi \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=je@fb.com \
--cc=john.stultz@linaro.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.