From: Thierry Reding <thierry.reding@gmail.com>
To: Ajay kumar <ajaynumb@gmail.com>
Cc: "linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
sunil joshi <joshi@samsung.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Prashanth G <prashanth.g@samsung.com>,
Ajay Kumar <ajaykumar.rs@samsung.com>
Subject: Re: [RFC V3 2/3] drm/bridge: add a dummy panel driver to support lvds bridges
Date: Sat, 17 May 2014 23:14:04 +0200 [thread overview]
Message-ID: <20140517211404.GC1046@mithrandir> (raw)
In-Reply-To: <CAEC9eQM_KtHDRaYGCmeT3f61+Rwh5oG2xWDNTTMkQCht6kAydQ@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1034 bytes --]
On Thu, May 15, 2014 at 05:10:16PM +0530, Ajay kumar wrote:
> On Thu, May 15, 2014 at 1:43 PM, Thierry Reding <thierry.reding@gmail.com> wrote:
[...]
> > I still don't see how controlling the enable GPIO from the panel will be
> > in any way better, or different for that matter, from simply enabling
> > the backlight and let the backlight driver handle the enable GPIO. Have
> > you tried to do that and found that it doesn't work?
> It works, but it gives me glitch when I try to configure video.
> This is because backlight_on(pwm-backlight) happens much before
> I configure video(inside drm), and while configuring video there would
> be a glitch,
> and that glitch would be visible to the user since backlight is already enabled.
Okay, so this means that your backlight is turned on too early. Instead
of working around that problem by moving control of the backlight enable
GPIO from the backlight driver into the panel driver, the correct way to
fix it is to make sure the backlight stays off until video is ready.
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2014-05-17 21:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 14:52 [RFC V3 0/3] drm/bridge: panel and chaining Ajay Kumar
2014-05-09 14:53 ` [RFC V3 1/3] drm/bridge: add helper functions to support bridge chain Ajay Kumar
2014-05-09 14:53 ` [RFC V3 2/3] drm/bridge: add a dummy panel driver to support lvds bridges Ajay Kumar
2014-05-13 8:05 ` Thierry Reding
2014-05-13 16:49 ` Ajay kumar
2014-05-14 14:54 ` Thierry Reding
2014-05-14 18:09 ` Ajay kumar
2014-05-15 8:13 ` Thierry Reding
2014-05-15 11:40 ` Ajay kumar
2014-05-17 20:33 ` Ajay kumar
2014-05-17 21:14 ` Thierry Reding [this message]
2014-05-18 8:20 ` Ajay kumar
2014-05-19 15:30 ` Thierry Reding
2014-05-19 19:07 ` Ajay kumar
2014-05-19 20:10 ` Thierry Reding
2014-06-03 9:58 ` Ajay kumar
2014-06-03 12:52 ` Andrzej Hajda
2014-05-09 14:53 ` [RFC V3 3/3] drm: create and demonstrate bridge chaining using exynos_dp Ajay Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140517211404.GC1046@mithrandir \
--to=thierry.reding@gmail.com \
--cc=a.hajda@samsung.com \
--cc=ajaykumar.rs@samsung.com \
--cc=ajaynumb@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=joshi@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=prashanth.g@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.