All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Masaru Nomura <massa.nomura@gmail.com>
Cc: gregkh@linuxfoundation.org, andreas.dilger@intel.com,
	oleg.drokin@intel.com, devel@driverdev.osuosl.org,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] staging: lustre: lnet: klnds: Fix coding style in socklnd.c
Date: Sun, 18 May 2014 20:33:27 +0000	[thread overview]
Message-ID: <20140518203327.GN15585@mwanda> (raw)
In-Reply-To: <1400433557-24985-1-git-send-email-massa.nomura@gmail.com>

On Sun, May 18, 2014 at 06:19:12PM +0100, Masaru Nomura wrote:
> These patches fix warnings below in socklnd.c to meet coding style.
> Also fix some indenting due to changes to keep readability.
> 
> WARNING: space prohibited between function name and open parenthesis '('
> WARNING: line over 80 characters
> 

All five of these do the same thing.  It should just be one patch.

regards,
dan carpenter


WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Masaru Nomura <massa.nomura@gmail.com>
Cc: gregkh@linuxfoundation.org, andreas.dilger@intel.com,
	oleg.drokin@intel.com, devel@driverdev.osuosl.org,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] staging: lustre: lnet: klnds: Fix coding style in socklnd.c
Date: Sun, 18 May 2014 23:33:27 +0300	[thread overview]
Message-ID: <20140518203327.GN15585@mwanda> (raw)
In-Reply-To: <1400433557-24985-1-git-send-email-massa.nomura@gmail.com>

On Sun, May 18, 2014 at 06:19:12PM +0100, Masaru Nomura wrote:
> These patches fix warnings below in socklnd.c to meet coding style.
> Also fix some indenting due to changes to keep readability.
> 
> WARNING: space prohibited between function name and open parenthesis '('
> WARNING: line over 80 characters
> 

All five of these do the same thing.  It should just be one patch.

regards,
dan carpenter


  parent reply	other threads:[~2014-05-18 20:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-18 17:19 [PATCH 0/5] staging: lustre: lnet: klnds: Fix coding style in socklnd.c Masaru Nomura
2014-05-18 17:19 ` Masaru Nomura
2014-05-18 17:19 ` [PATCH 1/5] staging: lustre: lnet: socklnd: Remove prohibited space Masaru Nomura
2014-05-18 17:19   ` Masaru Nomura
2014-05-18 17:19 ` [PATCH 2/5] staging: lustre: lnet: socklnd: Clean up memset(...) Masaru Nomura
2014-05-18 17:19   ` Masaru Nomura
2014-05-18 17:27   ` Joe Perches
2014-05-18 17:27     ` Joe Perches
2014-05-18 19:12     ` Masaru Nomura
2014-05-18 19:12       ` Masaru Nomura
2014-05-20  8:50     ` walter harms
2014-05-20  8:50       ` walter harms
2014-05-18 17:19 ` [PATCH 3/5] staging: lustre: lnet: socklnd: Clean up CDEBUG(...) Masaru Nomura
2014-05-18 17:19   ` Masaru Nomura
2014-05-18 17:19 ` [PATCH 4/5] staging: lustre: lnet: socklnd: Clean up ksocknal_get_peer_info(...) Masaru Nomura
2014-05-18 17:19   ` Masaru Nomura
2014-05-18 17:19 ` [PATCH 5/5] staging: lustre: lnet: socklnd: Clean up ksocknal_create_conn(...) Masaru Nomura
2014-05-18 17:19   ` Masaru Nomura
2014-05-18 20:33 ` Dan Carpenter [this message]
2014-05-18 20:33   ` [PATCH 0/5] staging: lustre: lnet: klnds: Fix coding style in socklnd.c Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140518203327.GN15585@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=massa.nomura@gmail.com \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.