Re: [PATCH v6] mm: support madvise(MADV_FREE)

[Minchan Kim <minchan@kernel.org>]

On Fri, May 16, 2014 at 10:38:00PM +0300, Kirill A. Shutemov wrote:
> On Fri, May 16, 2014 at 03:34:27PM +0900, Minchan Kim wrote:
> > > > +static inline unsigned long lazyfree_pmd_range(struct mmu_gather *tlb,
> > > > +				struct vm_area_struct *vma, pud_t *pud,
> > > > +				unsigned long addr, unsigned long end)
> > > > +{
> > > > +	pmd_t *pmd;
> > > > +	unsigned long next;
> > > > +
> > > > +	pmd = pmd_offset(pud, addr);
> > > > +	do {
> > > > +		next = pmd_addr_end(addr, end);
> > > > +		if (pmd_trans_huge(*pmd))
> > > > +			split_huge_page_pmd(vma, addr, pmd);
> > > 
> > > /* XXX */ as well? :)
> > 
> > You meant huge page unit lazyfree rather than 4K page unit?
> > If so, I will add.
> 
> Please, free huge page if range cover it. 


Yeb, We could do further patches if current patch's design is done
from reviewers.

Thanks.

> 
> -- 
>  Kirill A. Shutemov
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

-- 
Kind regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>