From: Dan Carpenter <dan.carpenter@oracle.com>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: lidza.louina@gmail.com, gregkh@linuxfoundation.org,
markh@compro.net, driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3] staging: dgap: implement error handling in dgap_tty_register()
Date: Mon, 19 May 2014 11:06:34 +0300 [thread overview]
Message-ID: <20140519080634.GM16255@mwanda> (raw)
In-Reply-To: <20140519021030.GA1051@devel.8.8.4.4>
On Mon, May 19, 2014 at 11:10:30AM +0900, Daeseok Youn wrote:
> diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
> index d7cfc45..e4cb7aa 100644
> --- a/drivers/staging/dgap/dgap.c
> +++ b/drivers/staging/dgap/dgap.c
> @@ -1212,7 +1212,9 @@ static int dgap_tty_register(struct board_t *brd)
> {
> int rc = 0;
Oh, and you may as well remove this initialization while you are at it.
regards,
dan carpenter
prev parent reply other threads:[~2014-05-19 8:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 2:10 [PATCH V3] staging: dgap: implement error handling in dgap_tty_register() Daeseok Youn
2014-05-19 8:02 ` Dan Carpenter
2014-05-19 9:39 ` DaeSeok Youn
2014-05-19 9:45 ` DaeSeok Youn
2014-05-19 8:06 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140519080634.GM16255@mwanda \
--to=dan.carpenter@oracle.com \
--cc=daeseok.youn@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.