From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: "Kevin Wolf" <kwolf@redhat.com>, "Fam Zheng" <famz@redhat.com>,
"Anthony Liguori" <aliguori@amazon.com>,
"Juan Quintela" <quintela@redhat.com>,
qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
"Amit Shah" <amit.shah@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
"Greg Kurz" <gkurz@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH RFC V2 0/8] virtio: migrate new properties
Date: Mon, 19 May 2014 18:10:08 +0300 [thread overview]
Message-ID: <20140519151008.GA22363@redhat.com> (raw)
In-Reply-To: <5379F2DF.2040909@suse.de>
On Mon, May 19, 2014 at 02:02:39PM +0200, Alexander Graf wrote:
>
> On 19.05.14 10:38, Greg Kurz wrote:
> >Hi,
> >
> >This patch set tries to address comments from the initial
> >review. For this round, I have focused on two changes:
> >- as suggested by Andreas, we now call the device specific
> > code from the generic code to ease the implementation of
> > future devices. This is achieved with the addition of
> > load/save methods to VirtioDeviceClass.
> >- virtio subsections now implement a "needed" concept with
> > the same semantics as in the VMState code.
> >
> >I haven't looked at compat mode issues yet, but it is
> >on my TODO list.
>
> If you fix up the comments to be either
>
> /*
> * foo
> */
>
> or
>
> /* foo */
>
> style, not
>
> /* foo
> */
>
> then you get my
>
>
> Acked-by: Alexander Graf <agraf@suse.de>
>
>
> Alex
Documented anywhere?
Linux style is
/* Always
* like this.
*/
so it's definitely not universal.
--
MST
next prev parent reply other threads:[~2014-05-19 15:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 8:38 [Qemu-devel] [PATCH RFC V2 0/8] virtio: migrate new properties Greg Kurz
2014-05-19 8:38 ` [Qemu-devel] [PATCH RFC 1/8] virtio: introduce device specific migration calls Greg Kurz
2014-05-19 8:38 ` [Qemu-devel] [PATCH RFC 2/8] virtio-net: implement per-device " Greg Kurz
2014-05-19 8:38 ` [Qemu-devel] [PATCH RFC 3/8] virtio-blk: " Greg Kurz
2014-05-19 8:38 ` [Qemu-devel] [PATCH RFC 4/8] virtio-serial: " Greg Kurz
2014-05-19 8:38 ` [Qemu-devel] [PATCH RFC 5/8] virtio-balloon: " Greg Kurz
2014-05-19 8:38 ` [Qemu-devel] [PATCH RFC 6/8] virtio-rng: " Greg Kurz
2014-05-19 8:39 ` [Qemu-devel] [PATCH RFC 7/8] virtio: add subsections to the migration stream Greg Kurz
2014-05-19 8:39 ` [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice Greg Kurz
2014-05-19 13:06 ` Greg Kurz
2014-05-19 17:06 ` Andreas Färber
2014-05-19 17:32 ` Greg Kurz
2014-05-19 18:07 ` Dr. David Alan Gilbert
2014-05-19 12:02 ` [Qemu-devel] [PATCH RFC V2 0/8] virtio: migrate new properties Alexander Graf
2014-05-19 12:45 ` Greg Kurz
2014-05-19 13:07 ` Alexander Graf
2014-05-19 15:10 ` Michael S. Tsirkin [this message]
2014-05-19 15:36 ` Alexander Graf
2014-05-19 15:50 ` Michael S. Tsirkin
2014-05-19 15:40 ` Andreas Färber
2014-05-19 15:53 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140519151008.GA22363@redhat.com \
--to=mst@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aliguori@amazon.com \
--cc=amit.shah@redhat.com \
--cc=famz@redhat.com \
--cc=gkurz@linux.vnet.ibm.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.