From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: Fix linker script entry point
Date: Mon, 19 May 2014 16:49:47 +0100 [thread overview]
Message-ID: <20140519154947.GJ15130@arm.com> (raw)
In-Reply-To: <1400261161.12756.15.camel@smoke>
On Fri, May 16, 2014 at 06:26:01PM +0100, Geoff Levand wrote:
> Change the arm64 linker script ENTRY() command to define _text as the
> kernel entry point.
>
> The arm64 boot protocol specifies that the kernel must be entered at the
> beginning of the kernel image. The existing ENTRY() command defined the
> symbol stext as the entry point, which emitted an incorrect entry point,
> but would not cause a runtime error because the existing entry code
> immediately jumps to stext.
>
> Signed-off-by: Geoff Levand <geoff@infradead.org>
> ---
> Hi Will,
>
> As requested, here is a fix for the linker script. There are a lot of ways
> we can define the entry point. Let me know if you want to do it differently.
Looks good to me, thanks:
Acked-by: Will Deacon <will.deacon@arm.com>
Will
> arch/arm64/kernel/vmlinux.lds.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/vmlinux.lds.S b/arch/arm64/kernel/vmlinux.lds.S
> index 4ba7a55..f1e6d5c 100644
> --- a/arch/arm64/kernel/vmlinux.lds.S
> +++ b/arch/arm64/kernel/vmlinux.lds.S
> @@ -13,7 +13,7 @@
> #define ARM_EXIT_DISCARD(x) x
>
> OUTPUT_ARCH(aarch64)
> -ENTRY(stext)
> +ENTRY(_text)
>
> jiffies = jiffies_64;
>
> --
> 1.9.1
>
>
>
>
prev parent reply other threads:[~2014-05-19 15:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 23:06 arm64 entry point Geoff Levand
2014-05-16 9:01 ` Will Deacon
2014-05-16 17:26 ` [PATCH] arm64: Fix linker script " Geoff Levand
2014-05-19 15:49 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140519154947.GJ15130@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.