From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: [PATCH net-next 2/4] net: systemport: use the new fixed PHY helpers Date: Tue, 20 May 2014 00:04:20 +0200 Message-ID: <20140520000420.7039e1bc@free-electrons.com> References: <1400528625-32744-1-git-send-email-f.fainelli@gmail.com> <1400528625-32744-3-git-send-email-f.fainelli@gmail.com> <20140519221946.27dbad55@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: netdev-owner@vger.kernel.org To: Florian Fainelli Cc: netdev , David Miller , "devicetree@vger.kernel.org" List-Id: devicetree@vger.kernel.org Dear Florian Fainelli, On Mon, 19 May 2014 14:52:57 -0700, Florian Fainelli wrote: > >> + /* SYSTEMPORT uses the old 'fixed-link' 5-digit property which is > >> + * deprecated, we need to register the fixed PHY using the Ethernet > >> + * MAC node since we do not have a 'fixed-link' subnode. > >> + */ > > > > Actually even if you use the new fixed PHY DT binding, the DT node > > linked to the PHY is the Ethernet MAC node. This is because I didn't > > want to have a difference between how things are handled between the > > old and the new binding. > > Sure, I agree, and the comment still stands, I am just expressing it > that we are not looking for the 'fixed-link' subnode, but the > 'fixed-link' 5-digit property here. Would you want me to rephrase > that? What I found misleading in the comment is that you simply to imply that because you're not using the new DT binding for fixed-link, the DT node that is associated to the PHY is the Ethernet MAC. The truth is that the DT node associated to the fixed PHY is always the Ethernet MAC, regardless of whether you're using the old or the new DT binding. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com