From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org,
Thavatchai Makphaibulchoke <thavatchai.makpahibulchoke@hp.com>
Subject: Re: [PATCH 2/2] ext4: Reduce contention on s_orphan_lock
Date: Mon, 19 May 2014 23:23:50 -0400 [thread overview]
Message-ID: <20140520032350.GB10122@thunk.org> (raw)
In-Reply-To: <1400185026-3972-3-git-send-email-jack@suse.cz>
On Thu, May 15, 2014 at 10:17:06PM +0200, Jan Kara wrote:
> Shuffle code around in ext4_orphan_add() and ext4_orphan_del() so that
> we avoid taking global s_orphan_lock in some cases and hold it for
> shorter time in other cases.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
Hi Jan,
With this patch applies, xfstests is hanging after ext4/001 runs:
BEGIN TEST: Ext4 4k block Tue May 20 03:18:49 UTC 2014
Device: /dev/vdb
mk2fs options: -q
mount options: -o block_validity
FSTYP -- ext4
PLATFORM -- Linux/i686 candygram 3.15.0-rc2-00052-g0f430fc
MKFS_OPTIONS -- -q /dev/vdc
MOUNT_OPTIONS -- -o acl,user_xattr -o block_validity /dev/vdc /vdc
ext4/001 4s ... [03:19:05] [03:19:09] 4s
It just stops here, and never runs the next test.
If I revert this commit, the test run continus with ext4/002, and then
onto the rest of the tests.
Could you take a look?
Thanks!!
- Ted
next prev parent reply other threads:[~2014-05-20 3:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 20:17 [PATCH 0/2 v2] Improve orphan list scaling Jan Kara
2014-05-15 20:17 ` [PATCH 1/2] ext4: Use sbi in ext4_orphan_{add|del}() Jan Kara
2014-05-15 20:17 ` [PATCH 2/2] ext4: Reduce contention on s_orphan_lock Jan Kara
2014-05-20 3:23 ` Theodore Ts'o [this message]
2014-05-20 8:33 ` Thavatchai Makphaibulchoke
2014-05-20 9:18 ` Jan Kara
2014-05-20 13:57 ` Theodore Ts'o
2014-05-20 17:16 ` Thavatchai Makphaibulchoke
2014-06-02 17:45 ` Thavatchai Makphaibulchoke
2014-06-03 8:52 ` Jan Kara
2014-06-16 19:20 ` Thavatchai Makphaibulchoke
2014-06-17 9:29 ` Jan Kara
2014-06-18 4:38 ` Thavatchai Makphaibulchoke
2014-06-18 10:37 ` Jan Kara
2014-07-22 4:35 ` Thavatchai Makphaibulchoke
2014-07-23 8:15 ` Jan Kara
2014-05-19 14:50 ` [PATCH 0/2 v2] Improve orphan list scaling Theodore Ts'o
-- strict thread matches above, loose matches on Subject: below --
2014-05-20 12:45 [PATCH 0/2 v3] " Jan Kara
2014-05-20 12:45 ` [PATCH 2/2] ext4: Reduce contention on s_orphan_lock Jan Kara
2014-05-20 16:45 ` Thavatchai Makphaibulchoke
2014-05-20 21:03 ` Jan Kara
2014-05-20 23:27 ` Thavatchai Makphaibulchoke
2014-04-29 23:32 [PATCH 0/2] " Jan Kara
2014-04-29 23:32 ` [PATCH 2/2] " Jan Kara
2014-05-02 21:56 ` Thavatchai Makphaibulchoke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140520032350.GB10122@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=thavatchai.makpahibulchoke@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.