From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Tue, 20 May 2014 08:20:48 +0100 Subject: [PATCH v4 6/6] ARM: dts: STiH407: Add B2120 board support In-Reply-To: References: <1394614210-15698-1-git-send-email-maxime.coquelin@st.com> <1394614210-15698-7-git-send-email-maxime.coquelin@st.com> Message-ID: <20140520072048.GC20874@lee--X1> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > > B2120 HDK is the reference board for STiH407 SoC. > > It has the following characteristics: > > - 1GB DDR3 > > - 8GB eMMC / SD-Card slot > > - 32MB NOR Flash > > - 1 x Gbit Ethernet > > - 1 x USB 3.0 port > > - 1 x Mini-PCIe > > - 1 x SATA > > - 1 x HDMI output > > - 1 x HDMI input > > - 1 x SPDIF > > > > This patch only introduces basic functionnalities, such as I2C and UART. > > > > Acked-by: Giuseppe Cavallaro > > Acked-by: Lee Jones > > Signed-off-by: Giuseppe Cavallaro > > Signed-off-by: Maxime Coquelin > > --- > > arch/arm/boot/dts/Makefile | 3 +- > > arch/arm/boot/dts/stih407-b2120.dts | 78 +++++++++++++++++++++++++++++++++++++ > > 2 files changed, 80 insertions(+), 1 deletion(-) > > create mode 100644 arch/arm/boot/dts/stih407-b2120.dts [...] > > +/ { > > + model = "STiH407 B2120"; > > + compatible = "st,stih407", "st,stih407-b2120"; > > This should go from specific to generic, so the order needs to be the other way. I did have a patch-set that changed all of these. Wonder where that went! [...] > > + soc { > > + sbc_serial0: serial at 9530000 { > > + status = "okay"; > > + }; > > You might want to consider reference-based syntax here instead, so you > don't have to mimic the hierarchy. That'd be (at the root level of the > file, below this secion: > > &sbc_serial0: { > status = "okay"; > }; I'm personally not keen on this scheme. It's sometimes helpful to know the hierarchy and I don't think it's a large overhead to format the subordinate DTS files in this way. Please consider not enforcing this. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v4 6/6] ARM: dts: STiH407: Add B2120 board support Date: Tue, 20 May 2014 08:20:48 +0100 Message-ID: <20140520072048.GC20874@lee--X1> References: <1394614210-15698-1-git-send-email-maxime.coquelin@st.com> <1394614210-15698-7-git-send-email-maxime.coquelin@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Olof Johansson Cc: Mark Rutland , "devicetree@vger.kernel.org" , Russell King , kernel@stlinux.com, Pawel Moll , Ian Campbell , Linus Walleij , Srinivas Kandagatla , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Stuart Menefy , Rob Herring , Rob Landley , Kumar Gala , Giuseppe Cavallaro , "linux-arm-kernel@lists.infradead.org" , Maxime COQUELIN List-Id: devicetree@vger.kernel.org PiA+IEIyMTIwIEhESyBpcyB0aGUgcmVmZXJlbmNlIGJvYXJkIGZvciBTVGlINDA3IFNvQy4KPiA+ IEl0IGhhcyB0aGUgZm9sbG93aW5nIGNoYXJhY3RlcmlzdGljczoKPiA+ICAtIDFHQiBERFIzCj4g PiAgLSA4R0IgZU1NQyAvIFNELUNhcmQgc2xvdAo+ID4gIC0gMzJNQiBOT1IgRmxhc2gKPiA+ICAt IDEgeCBHYml0IEV0aGVybmV0Cj4gPiAgLSAxIHggVVNCIDMuMCBwb3J0Cj4gPiAgLSAxIHggTWlu aS1QQ0llCj4gPiAgLSAxIHggU0FUQQo+ID4gIC0gMSB4IEhETUkgb3V0cHV0Cj4gPiAgLSAxIHgg SERNSSBpbnB1dAo+ID4gIC0gMSB4IFNQRElGCj4gPgo+ID4gVGhpcyBwYXRjaCBvbmx5IGludHJv ZHVjZXMgYmFzaWMgZnVuY3Rpb25uYWxpdGllcywgc3VjaCBhcyBJMkMgYW5kIFVBUlQuCj4gPgo+ ID4gQWNrZWQtYnk6IEdpdXNlcHBlIENhdmFsbGFybyA8cGVwcGUuY2F2YWxsYXJvQHN0LmNvbT4K PiA+IEFja2VkLWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgo+ID4gU2lnbmVk LW9mZi1ieTogR2l1c2VwcGUgQ2F2YWxsYXJvIDxwZXBwZS5jYXZhbGxhcm9Ac3QuY29tPgo+ID4g U2lnbmVkLW9mZi1ieTogTWF4aW1lIENvcXVlbGluIDxtYXhpbWUuY29xdWVsaW5Ac3QuY29tPgo+ ID4gLS0tCj4gPiAgYXJjaC9hcm0vYm9vdC9kdHMvTWFrZWZpbGUgICAgICAgICAgfCAgMyArLQo+ ID4gIGFyY2gvYXJtL2Jvb3QvZHRzL3N0aWg0MDctYjIxMjAuZHRzIHwgNzggKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKwo+ID4gIDIgZmlsZXMgY2hhbmdlZCwgODAgaW5zZXJ0 aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ID4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBhcmNoL2FybS9i b290L2R0cy9zdGloNDA3LWIyMTIwLmR0cwoKWy4uLl0KCj4gPiArLyB7Cj4gPiArICAgICAgIG1v ZGVsID0gIlNUaUg0MDcgQjIxMjAiOwo+ID4gKyAgICAgICBjb21wYXRpYmxlID0gInN0LHN0aWg0 MDciLCAic3Qsc3RpaDQwNy1iMjEyMCI7Cj4gCj4gVGhpcyBzaG91bGQgZ28gZnJvbSBzcGVjaWZp YyB0byBnZW5lcmljLCBzbyB0aGUgb3JkZXIgbmVlZHMgdG8gYmUgdGhlIG90aGVyIHdheS4KCkkg ZGlkIGhhdmUgYSBwYXRjaC1zZXQgdGhhdCBjaGFuZ2VkIGFsbCBvZiB0aGVzZS4gIFdvbmRlciB3 aGVyZSB0aGF0IHdlbnQhCgpbLi4uXQoKPiA+ICsgICAgICAgc29jIHsKPiA+ICsgICAgICAgICAg ICAgICBzYmNfc2VyaWFsMDogc2VyaWFsQDk1MzAwMDAgewo+ID4gKyAgICAgICAgICAgICAgICAg ICAgICAgc3RhdHVzID0gIm9rYXkiOwo+ID4gKyAgICAgICAgICAgICAgIH07Cj4gCj4gWW91IG1p Z2h0IHdhbnQgdG8gY29uc2lkZXIgcmVmZXJlbmNlLWJhc2VkIHN5bnRheCBoZXJlIGluc3RlYWQs IHNvIHlvdQo+IGRvbid0IGhhdmUgdG8gbWltaWMgdGhlIGhpZXJhcmNoeS4gVGhhdCdkIGJlIChh dCB0aGUgcm9vdCBsZXZlbCBvZiB0aGUKPiBmaWxlLCBiZWxvdyB0aGlzIHNlY2lvbjoKPiAKPiAm c2JjX3NlcmlhbDA6IHsKPiAgICAgICAgIHN0YXR1cyA9ICJva2F5IjsKPiB9OwoKSSdtIHBlcnNv bmFsbHkgbm90IGtlZW4gb24gdGhpcyBzY2hlbWUuICBJdCdzIHNvbWV0aW1lcyBoZWxwZnVsIHRv IGtub3cKdGhlIGhpZXJhcmNoeSBhbmQgSSBkb24ndCB0aGluayBpdCdzIGEgbGFyZ2Ugb3Zlcmhl YWQgdG8gZm9ybWF0IHRoZQpzdWJvcmRpbmF0ZSBEVFMgZmlsZXMgaW4gdGhpcyB3YXkuCgpQbGVh c2UgY29uc2lkZXIgbm90IGVuZm9yY2luZyB0aGlzLgoKLS0gCkxlZSBKb25lcwpMaW5hcm8gU1RN aWNyb2VsZWN0cm9uaWNzIExhbmRpbmcgVGVhbSBMZWFkCkxpbmFyby5vcmcg4pSCIE9wZW4gc291 cmNlIHNvZnR3YXJlIGZvciBBUk0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0 ZXIgfCBCbG9nCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752252AbaETHU5 (ORCPT ); Tue, 20 May 2014 03:20:57 -0400 Received: from mail-ie0-f174.google.com ([209.85.223.174]:58551 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752157AbaETHUz (ORCPT ); Tue, 20 May 2014 03:20:55 -0400 Date: Tue, 20 May 2014 08:20:48 +0100 From: Lee Jones To: Olof Johansson Cc: Maxime COQUELIN , Rob Landley , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Srinivas Kandagatla , Stuart Menefy , Linus Walleij , Giuseppe Cavallaro , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , kernel@stlinux.com Subject: Re: [PATCH v4 6/6] ARM: dts: STiH407: Add B2120 board support Message-ID: <20140520072048.GC20874@lee--X1> References: <1394614210-15698-1-git-send-email-maxime.coquelin@st.com> <1394614210-15698-7-git-send-email-maxime.coquelin@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > B2120 HDK is the reference board for STiH407 SoC. > > It has the following characteristics: > > - 1GB DDR3 > > - 8GB eMMC / SD-Card slot > > - 32MB NOR Flash > > - 1 x Gbit Ethernet > > - 1 x USB 3.0 port > > - 1 x Mini-PCIe > > - 1 x SATA > > - 1 x HDMI output > > - 1 x HDMI input > > - 1 x SPDIF > > > > This patch only introduces basic functionnalities, such as I2C and UART. > > > > Acked-by: Giuseppe Cavallaro > > Acked-by: Lee Jones > > Signed-off-by: Giuseppe Cavallaro > > Signed-off-by: Maxime Coquelin > > --- > > arch/arm/boot/dts/Makefile | 3 +- > > arch/arm/boot/dts/stih407-b2120.dts | 78 +++++++++++++++++++++++++++++++++++++ > > 2 files changed, 80 insertions(+), 1 deletion(-) > > create mode 100644 arch/arm/boot/dts/stih407-b2120.dts [...] > > +/ { > > + model = "STiH407 B2120"; > > + compatible = "st,stih407", "st,stih407-b2120"; > > This should go from specific to generic, so the order needs to be the other way. I did have a patch-set that changed all of these. Wonder where that went! [...] > > + soc { > > + sbc_serial0: serial@9530000 { > > + status = "okay"; > > + }; > > You might want to consider reference-based syntax here instead, so you > don't have to mimic the hierarchy. That'd be (at the root level of the > file, below this secion: > > &sbc_serial0: { > status = "okay"; > }; I'm personally not keen on this scheme. It's sometimes helpful to know the hierarchy and I don't think it's a large overhead to format the subordinate DTS files in this way. Please consider not enforcing this. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog