From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH] gpio / ACPI: use *_cansleep version of gpiod_get/set APIs Date: Tue, 20 May 2014 11:50:50 +0300 Message-ID: <20140520085050.GF1651@lahna.fi.intel.com> References: <537B15A0.3080406@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga09.intel.com ([134.134.136.24]:31746 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751650AbaETIvQ (ORCPT ); Tue, 20 May 2014 04:51:16 -0400 Content-Disposition: inline In-Reply-To: <537B15A0.3080406@intel.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Aaron Lu Cc: Linus Walleij , Alexandre Courbot , linux-gpio@vger.kernel.org On Tue, May 20, 2014 at 04:43:12PM +0800, Aaron Lu wrote: > The GPIO operation region handler should be called where sleep is > allowed, so we should use the *_cansleep version of gpiod_get/set APIs > or we will get a warning message complaining invalid context if the GPIO > chip has the cansleep flag set. > > Signed-off-by: Aaron Lu > Acked-by: Mika Westerberg > --- > drivers/gpio/gpiolib-acpi.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c > index bf0f8b4..2d398a6 100644 > --- a/drivers/gpio/gpiolib-acpi.c > +++ b/drivers/gpio/gpiolib-acpi.c > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include Why the above include? (Sorry I just noticed this now). > > #include "gpiolib.h" > > @@ -449,9 +450,10 @@ acpi_gpio_adr_space_handler(u32 function, acpi_physical_address address, > mutex_unlock(&achip->conn_lock); > > if (function == ACPI_WRITE) > - gpiod_set_raw_value(desc, !!((1 << i) & *value)); > + gpiod_set_raw_value_cansleep(desc, > + !!((1 << i) & *value)); > else > - *value |= gpiod_get_raw_value(desc) << i; > + *value |= gpiod_get_raw_value_cansleep(desc) << i; > } > > out: > -- > 1.9.0