From: "John W. Linville" <linville@tuxdriver.com>
To: Emmanuel Grumbach <egrumbach@gmail.com>
Cc: linux-wireless@vger.kernel.org,
Avri Altman <avri.altman@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Subject: Re: [PATCH] iwlwifi: mvm: don't filter out the first beacon
Date: Tue, 20 May 2014 10:32:26 -0400 [thread overview]
Message-ID: <20140520143226.GC13981@tuxdriver.com> (raw)
In-Reply-To: <1400582238-18601-1-git-send-email-egrumbach@gmail.com>
On Tue, May 20, 2014 at 01:37:18PM +0300, Emmanuel Grumbach wrote:
> From: Avri Altman <avri.altman@intel.com>
>
> Enabling beacon filtering should be done only after a beacon
> has been received. Doing that too early will cause
> disconnections.
> This has already been fixed, but the fix didn't take care
> about the case where the beacon is received after the
> association, it waited only for association which is not
> enough.
>
> Signed-off-by: Avri Altman <avri.altman@intel.com>
> Reviewed-by: Johannes Berg <johannes.berg@intel.com>
> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> ---
> drivers/net/wireless/iwlwifi/mvm/mac80211.c | 13 +++---
> drivers/net/wireless/iwlwifi/mvm/mvm.h | 5 ---
> drivers/net/wireless/iwlwifi/mvm/power.c | 63 +++++++++--------------------
> 3 files changed, 27 insertions(+), 54 deletions(-)
It is very late in the release cycle for a fix of this size.
How serious is the issue? A random disconnect doesn't seem like a
huge problem so long as it isn't common...?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2014-05-20 14:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 10:35 pull request: iwlwifi 2014-05-20 Emmanuel Grumbach
2014-05-20 10:37 ` [PATCH] iwlwifi: mvm: don't filter out the first beacon Emmanuel Grumbach
2014-05-20 14:32 ` John W. Linville [this message]
2014-05-20 15:18 ` Eliad Peller
2014-05-20 16:38 ` Grumbach, Emmanuel
2014-05-21 6:22 ` Altman, Avri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140520143226.GC13981@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=avri.altman@intel.com \
--cc=egrumbach@gmail.com \
--cc=emmanuel.grumbach@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.