From: Christoph Hellwig <hch@lst.de>
To: nickkrause@sympatico.ca, sandeen@redhat.com
Cc: xfs@oss.sgi.com
Subject: Re: [xfs-masters] [Bug 48651] [TRIVIAl]'xfs_uuid_table' allocated in xfs_uuid_mount() is never freed
Date: Tue, 20 May 2014 16:40:46 +0200 [thread overview]
Message-ID: <20140520144046.GA17616@lst.de> (raw)
In-Reply-To: <bug-48651-470-8kNPGrGVTO@https.bugzilla.kernel.org/>
On Tue, May 20, 2014 at 04:01:20AM +0000, bugzilla-daemon@bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=48651
> --- Comment #2 from Eric Sandeen <sandeen@redhat.com> ---
> Freeing it when the module is unloaded should be sufficient.
>
> In normal use, unmounting a filesystem creates a hole in the table, which the
> next mount can fill.
>
> If you mount a lot of unique UUID filesystems without unmounting any in
> between, the table will grow accordingly, and unmounting won't shrink it - i.e.
> the table only grows as the number of concurrently mounted filesystem grows,
> but that doesn't seem like a particularly critical problem to fix.
If anyonereally cares about this he or she should just kill the uuid
table entirely. We can simple walk a list of mounted xfs filesystems
and check their uuids. The VFS even keeps a list already, which we
probably could use if we are careful.
Bonus points for implementing this in a way so that other filesystems
could share the code.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
parent reply other threads:[~2014-05-20 14:40 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <bug-48651-470-8kNPGrGVTO@https.bugzilla.kernel.org/>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140520144046.GA17616@lst.de \
--to=hch@lst.de \
--cc=nickkrause@sympatico.ca \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.