From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [PATCH 7/8] radeon: Out of line radeon_get_ib_value Date: Tue, 20 May 2014 10:04:49 -0700 Message-ID: <20140520170449.GK19657@tassilo.jf.intel.com> References: <1400276595-6965-1-git-send-email-andi@firstfloor.org> <1400276595-6965-8-git-send-email-andi@firstfloor.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Marek =?utf-8?B?T2zFocOhaw==?= Cc: Andi Kleen , linux-kernel@vger.kernel.org, "Deucher, Alexander" , akpm@linux-foundation.org, dri-devel List-Id: dri-devel@lists.freedesktop.org On Tue, May 20, 2014 at 06:16:48PM +0200, Marek Ol=C5=A1=C3=A1k wrote: > I think the function should stay in the header file. It's used in > performance-critical code, so we want it to be inlined. This doesn't make any sense. If it's talking to the hardware it will be dominated by the cache misses. -Andi