From: Lee Jones <lee.jones@linaro.org>
To: Robert Baldyga <r.baldyga@samsung.com>
Cc: sameo@linux.intel.com, a.zummo@towertech.it,
linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
m.szyprowski@samsung.com, k.kozlowski@samsung.com
Subject: Re: [RESEND PATCH v2] mfd: max77686: handle IRQs using regmap
Date: Tue, 20 May 2014 18:32:50 +0100 [thread overview]
Message-ID: <20140520173250.GD32538@lee--X1> (raw)
In-Reply-To: <20140520161543.GC32025@lee--X1>
> > This patch modifies mfd driver to use regmap for handling interrupts.
> > It allows to simplify irq handling process. This modifications needed
> > to make small changes in function drivers, which use interrupts.
> >
> > Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
> > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > ---
> > drivers/mfd/Kconfig | 2 +-
> > drivers/mfd/Makefile | 2 +-
> > drivers/mfd/max77686-irq.c | 319 -----------------------------------
> > drivers/mfd/max77686.c | 54 +++++-
> > drivers/rtc/rtc-max77686.c | 43 ++++-
> > include/linux/mfd/max77686-private.h | 32 +++-
> > 6 files changed, 119 insertions(+), 333 deletions(-)
> > delete mode 100644 drivers/mfd/max77686-irq.c
>
> I'm not going to complain at that diffstat.
>
> So long as it works, patch applied.
Slight change of plan, as it no longer applies. Can you rebase the
patch, apply my Acked-by and resubmit please?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2014-05-20 17:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 13:41 [RESEND PATCH v2] mfd: max77686: handle IRQs using regmap Robert Baldyga
2014-05-20 16:15 ` Lee Jones
2014-05-20 17:32 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140520173250.GD32538@lee--X1 \
--to=lee.jones@linaro.org \
--cc=a.zummo@towertech.it \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=r.baldyga@samsung.com \
--cc=rtc-linux@googlegroups.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.