From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Wed, 21 May 2014 10:29:13 +0100 Subject: [PATCH v2 4/4] ARM: dts: bcm590xx: add support for GPLDO and VBUS regulators In-Reply-To: <1398295293-11033-5-git-send-email-mporter@linaro.org> References: <1398295293-11033-1-git-send-email-mporter@linaro.org> <1398295293-11033-5-git-send-email-mporter@linaro.org> Message-ID: <20140521092913.GG6679@lee--X1> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > Adds additional nodes to support GPLDO1-6 and VBUS regulators which > are now supported in the bcm590xx regulator driver. > > Signed-off-by: Matt Porter > --- > arch/arm/boot/dts/bcm59056.dtsi | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) I'm not going to apply this with the rest of the set. It will have to go in via your normal arch/arm route. > diff --git a/arch/arm/boot/dts/bcm59056.dtsi b/arch/arm/boot/dts/bcm59056.dtsi > index dfadaaa..066adfb 100644 > --- a/arch/arm/boot/dts/bcm59056.dtsi > +++ b/arch/arm/boot/dts/bcm59056.dtsi > @@ -70,5 +70,26 @@ > > vsr_reg: vsr { > }; > + > + gpldo1_reg: gpldo1 { > + }; What do these empty nodes do in any case? Don't you at least need a status property in there or something? > + gpldo2_reg: gpldo2 { > + }; > + > + gpldo3_reg: gpldo3 { > + }; > + > + gpldo4_reg: gpldo4 { > + }; > + > + gpldo5_reg: gpldo5 { > + }; > + > + gpldo6_reg: gpldo6 { > + }; > + > + vbus_reg: vbus { > + }; > }; > }; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v2 4/4] ARM: dts: bcm590xx: add support for GPLDO and VBUS regulators Date: Wed, 21 May 2014 10:29:13 +0100 Message-ID: <20140521092913.GG6679@lee--X1> References: <1398295293-11033-1-git-send-email-mporter@linaro.org> <1398295293-11033-5-git-send-email-mporter@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1398295293-11033-5-git-send-email-mporter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Matt Porter Cc: Devicetree List , Samuel Ortiz , Liam Girdwood , Mark Brown , Tim Kryger , Markus Mayer , Linux Kernel Mailing List , Linux ARM Kernel List List-Id: devicetree@vger.kernel.org > Adds additional nodes to support GPLDO1-6 and VBUS regulators which > are now supported in the bcm590xx regulator driver. >=20 > Signed-off-by: Matt Porter > --- > arch/arm/boot/dts/bcm59056.dtsi | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) I'm not going to apply this with the rest of the set. It will have to go in via your normal arch/arm route. > diff --git a/arch/arm/boot/dts/bcm59056.dtsi b/arch/arm/boot/dts/bcm5= 9056.dtsi > index dfadaaa..066adfb 100644 > --- a/arch/arm/boot/dts/bcm59056.dtsi > +++ b/arch/arm/boot/dts/bcm59056.dtsi > @@ -70,5 +70,26 @@ > =20 > vsr_reg: vsr { > }; > + > + gpldo1_reg: gpldo1 { > + }; What do these empty nodes do in any case? Don't you at least need a status property in there or something? > + gpldo2_reg: gpldo2 { > + }; > + > + gpldo3_reg: gpldo3 { > + }; > + > + gpldo4_reg: gpldo4 { > + }; > + > + gpldo5_reg: gpldo5 { > + }; > + > + gpldo6_reg: gpldo6 { > + }; > + > + vbus_reg: vbus { > + }; > }; > }; --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752056AbaEUJ3U (ORCPT ); Wed, 21 May 2014 05:29:20 -0400 Received: from mail-ig0-f172.google.com ([209.85.213.172]:49748 "EHLO mail-ig0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751018AbaEUJ3T (ORCPT ); Wed, 21 May 2014 05:29:19 -0400 Date: Wed, 21 May 2014 10:29:13 +0100 From: Lee Jones To: Matt Porter Cc: Devicetree List , Samuel Ortiz , Liam Girdwood , Mark Brown , Tim Kryger , Markus Mayer , Linux Kernel Mailing List , Linux ARM Kernel List Subject: Re: [PATCH v2 4/4] ARM: dts: bcm590xx: add support for GPLDO and VBUS regulators Message-ID: <20140521092913.GG6679@lee--X1> References: <1398295293-11033-1-git-send-email-mporter@linaro.org> <1398295293-11033-5-git-send-email-mporter@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1398295293-11033-5-git-send-email-mporter@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Adds additional nodes to support GPLDO1-6 and VBUS regulators which > are now supported in the bcm590xx regulator driver. > > Signed-off-by: Matt Porter > --- > arch/arm/boot/dts/bcm59056.dtsi | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) I'm not going to apply this with the rest of the set. It will have to go in via your normal arch/arm route. > diff --git a/arch/arm/boot/dts/bcm59056.dtsi b/arch/arm/boot/dts/bcm59056.dtsi > index dfadaaa..066adfb 100644 > --- a/arch/arm/boot/dts/bcm59056.dtsi > +++ b/arch/arm/boot/dts/bcm59056.dtsi > @@ -70,5 +70,26 @@ > > vsr_reg: vsr { > }; > + > + gpldo1_reg: gpldo1 { > + }; What do these empty nodes do in any case? Don't you at least need a status property in there or something? > + gpldo2_reg: gpldo2 { > + }; > + > + gpldo3_reg: gpldo3 { > + }; > + > + gpldo4_reg: gpldo4 { > + }; > + > + gpldo5_reg: gpldo5 { > + }; > + > + gpldo6_reg: gpldo6 { > + }; > + > + vbus_reg: vbus { > + }; > }; > }; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog