From: Dan Carpenter <dan.carpenter@oracle.com>
To: jonas.jensen@gmail.com
Cc: linux-mmc@vger.kernel.org
Subject: re: mmc: moxart: Add MOXA ART SD/MMC driver
Date: Wed, 21 May 2014 15:28:25 +0300 [thread overview]
Message-ID: <20140521122825.GE23396@mwanda> (raw)
Hello Jonas Jensen,
The patch 1b66e94e6b99: "mmc: moxart: Add MOXA ART SD/MMC driver"
from Apr 9, 2014, leads to the following static checker warning:
drivers/mmc/host/moxart-mmc.c:691 moxart_remove()
warn: variable dereferenced before check 'mmc' (see line 687)
drivers/mmc/host/moxart-mmc.c
684 static int moxart_remove(struct platform_device *pdev)
685 {
686 struct mmc_host *mmc = dev_get_drvdata(&pdev->dev);
687 struct moxart_host *host = mmc_priv(mmc);
^^^^^^^^^^^^^
Dereference.
688
689 dev_set_drvdata(&pdev->dev, NULL);
690
691 if (mmc) {
^^^
Check.
692 if (!IS_ERR(host->dma_chan_tx))
regards,
dan carpenter
next reply other threads:[~2014-05-21 12:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 12:28 Dan Carpenter [this message]
2014-05-21 12:33 ` mmc: moxart: Add MOXA ART SD/MMC driver Arnd Bergmann
2014-05-21 12:52 ` Jonas Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140521122825.GE23396@mwanda \
--to=dan.carpenter@oracle.com \
--cc=jonas.jensen@gmail.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.