From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH V2 5/7] cpufreq: imx6q: don't initialize opp table Date: Wed, 21 May 2014 22:16:24 +0800 Message-ID: <20140521141622.GB27211@dragon> References: <537CB328.6000400@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Received: from mail-bn1lp0144.outbound.protection.outlook.com ([207.46.163.144]:52746 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751395AbaEUOQo (ORCPT ); Wed, 21 May 2014 10:16:44 -0400 Content-Disposition: inline In-Reply-To: <537CB328.6000400@arm.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Sudeep Holla Cc: Viresh Kumar , "rjw@rjwysocki.net" , "linaro-kernel@lists.linaro.org" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Arvind Chauhan , "inderpal.s@samsung.com" , "nm@ti.com" , "chander.kashyap@linaro.org" , "pavel@ucw.cz" , "len.brown@intel.com" On Wed, May 21, 2014 at 03:07:36PM +0100, Sudeep Holla wrote: > >@@ -376,7 +356,7 @@ static void __init imx6q_init_late(void) > > imx6q_cpuidle_init(); > > > > if (IS_ENABLED(CONFIG_ARM_IMX6Q_CPUFREQ)) { > >- imx6q_opp_init(); > >+ imx6q_opp_check_speed_grading(); > > [Query] Not exactly related to this patch, but asking it here to get clarified. > > This OPP limiting is done as part of late initcall and if the cpufreq driver is > built in the kernel, there will be a small window where the OPPs not supported > are still enabled ? Will that not be an issue if say performance governor is > selected by default. Even if cpufreq driver is built in the kernel, it won't be probed until platform_device_register(&imx6q_cpufreq_pdev) is called. And we make this call only after the OPP limiting. Shawn