From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49480)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1Wn7S0-0007pS-9e
	for qemu-devel@nongnu.org; Wed, 21 May 2014 10:25:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1Wn7Rr-00071n-HV
	for qemu-devel@nongnu.org; Wed, 21 May 2014 10:25:00 -0400
Received: from mx1.redhat.com ([209.132.183.28]:16620)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1Wn7Rr-00071E-2h
	for qemu-devel@nongnu.org; Wed, 21 May 2014 10:24:51 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4LEOovJ015244
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 21 May 2014 10:24:50 -0400
Date: Wed, 21 May 2014 10:24:48 -0400
From: Jeff Cody <jcody@redhat.com>
Message-ID: <20140521142448.GC13700@localhost.localdomain>
References: <1400565880-13409-1-git-send-email-famz@redhat.com>
	<1400565880-13409-7-git-send-email-famz@redhat.com>
	<20140521140303.GG6619@stefanha-thinkpad.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140521140303.GG6619@stefanha-thinkpad.redhat.com>
Subject: Re: [Qemu-devel] [PATCH v20 06/15] block: Add backing_blocker in
	BlockDriverState
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: kwolf@redhat.com, Fam Zheng <famz@redhat.com>, armbru@redhat.com, hbrock@redhat.com, rjones@redhat.com, qemu-devel@nongnu.org, imain@redhat.com, pbonzini@redhat.com

On Wed, May 21, 2014 at 04:03:03PM +0200, Stefan Hajnoczi wrote:
> On Tue, May 20, 2014 at 02:04:31PM +0800, Fam Zheng wrote:
> > diff --git a/block/mirror.c b/block/mirror.c
> > index 1c38aa8..6a53d79 100644
> > --- a/block/mirror.c
> > +++ b/block/mirror.c
> > @@ -499,6 +499,7 @@ immediate_exit:
> >               * trigger the unref from the top one */
> >              BlockDriverState *p = s->base->backing_hd;
> >              s->base->backing_hd = NULL;
> > +            bdrv_op_unblock_all(p, s->base->backing_blocker);
> >              bdrv_unref(p);
> >          }
> >      }
> 
> Would be cleaner to call bdrv_set_backing_hd(s->base, NULL) here instead
> of open coding it.
>

Patch 10 gets rid of essentially this whole chunk of code, and
replaces it with bdrv_drop_intermediate(). So it does get cleaned up,
just later in the series.