From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/exynos: Fix PTN3460 dependency Date: Wed, 21 May 2014 17:51:02 +0200 Message-ID: <20140521155059.GP2014@ulmo> References: <20140520111525.3a62e25d@endymion.delvare> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0311692383==" Return-path: Received: from mail-ee0-f50.google.com (mail-ee0-f50.google.com [74.125.83.50]) by gabe.freedesktop.org (Postfix) with ESMTP id 221D26E34E for ; Wed, 21 May 2014 08:53:20 -0700 (PDT) Received: by mail-ee0-f50.google.com with SMTP id e51so1787006eek.9 for ; Wed, 21 May 2014 08:53:20 -0700 (PDT) In-Reply-To: <20140520111525.3a62e25d@endymion.delvare> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jean Delvare Cc: Kyungmin Park , Kukjin Kim , Seung-Woo Kim , Alexander Graf , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0311692383== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ga5bsqHr1s/xcZEm" Content-Disposition: inline --ga5bsqHr1s/xcZEm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 20, 2014 at 11:15:25AM +0200, Jean Delvare wrote: > The following configuration options combination: >=20 > CONFIG_DRM_EXYNOS_DP=3Dy > CONFIG_DRM_PTN3460=3Dm >=20 > currently leads to the following linker failure: >=20 > drivers/built-in.o: In function `exynos_drm_attach_lcd_bridge': > .../drivers/gpu/drm/exynos/exynos_dp_core.c:1004: > undefined reference to `ptn3460_init' >=20 > This is because ptn3460_init can't be implemented in a module while > its caller is built into the kernel. So add the proper dependency in > Kconfig so that the above can't happen. >=20 > I moved DRM_PTN3460 earlier in Kconfig, next to the I2C helper module > section, so that the user has a chance to select it before moving to > the Exynos-specific section. >=20 > IMHO the proper way to solve the problem would be to turn ptn3460 into > a clean I2C driver, similar to the other I2C helper chip drivers. It's > the only way to not sink into impossible-to-guess dependencies. Then > ptn3460 could even be moved together with the other I2C helper chip > drivers. FWIW, various ideas have been discussed to solve this problem. The most recent agreement I think was to create a registry for bridge drivers to register DRM bridge objects against and allow drivers to look them up. That way we can get rid of the various *_init() functions that currently need to be called directly from within DRM drivers. I'm not aware of anybody working on this currently, hence I think this is an appropriate fix in the meantime: Reviewed-by: Thierry Reding --ga5bsqHr1s/xcZEm Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTfMtjAAoJEN0jrNd/PrOh0R0P/AgiBZ3NBePEMFsqNio/AgVz RFPA1jOlloTd8TmyXc4LnooZIE7OS3ucbEfocXTJsnxkjdf7EwJ8/ZxRC8dpsaPJ DAOc7PlywZi5iNSoY9shdSmGDncbKd6ehbs+CSDR1Vz2Lj76K5B/Qo5riCz3YrNg lSTxPiAc2vgsbspDxe0+XLn+oOYNcyIvJutnj4VVBNK1bt+MAgAlmUWVT5ACenE5 GVyZKXBCisjv+g06WYwkWoQUZgh3mTylz67xsJOnspQGSR890fDPZnxsPOB3aevF l3ai+RvVvx+Ts99h8gBqD1NrKWrvPWsDFGDHC2vSQG9DF51Y4zHqLcHAirLAEIYQ bG7OpKqZrsEktMKkCKK3Q2J/u0lVcFz48o+Vb6zEJpiMztR2qhOgBtidTvAsnmb7 4ZPyL9WRUe21g1ktV+VxLmP4g4yulZv7/D6XbEQ0HPMpmL1nh9JqKt4Amj/EL2xU 5e99JDBWOXlCXgx9rPbYWK0//XbiCTf7poi0/1I5WN7xqKtaUUaiPcPxGx70G9LC xrNj+uvFwpcZs7I4YagYS0RZseSJvCWMsPF65BEap6eafICEx2kjHpIy4CVphcjy BFhsu0J2wqEAx/CK18t1cBsDvgSlmqbuVSIqiEkNHL2Zu5XY4exWWUK03LH/07Iz sGAjcCsuYr+s4f8S+jy8 =stB4 -----END PGP SIGNATURE----- --ga5bsqHr1s/xcZEm-- --===============0311692383== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0311692383==--