All of lore.kernel.org
 help / color / mirror / Atom feed
From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] pinctrl/at91: Fix lockup when IRQ on PIOC and PIOD occurs
Date: Wed, 21 May 2014 19:15:32 +0200	[thread overview]
Message-ID: <20140521171532.GH3582@piout.net> (raw)
In-Reply-To: <536CAC87.9070007@atmel.com>

Hi Linus,

On 09/05/2014 at 12:23:03 +0200, Nicolas Ferre wrote :
> On 25/04/2014 11:18, Linus Walleij :
> > On Thu, Apr 24, 2014 at 7:55 PM, Alexander Stein <alexanders83@web.de> wrote:
> > 
> >> With commit 80cc3732 (pinctrl/at91: convert driver to use gpiolib irqchip)
> >> gpiochip_set_chained_irqchip is called for PIOC, PIOD and PIOE. The
> >> associated GPIO chip for the IRQ chip is overwritten each time, because
> >> they share the same hard IRQ line.
> >> Thus if an IRQ occurs on PIOC or PIOD, gpio_irq_handler will only check on
> >> PIOE (the assigned GPIO chip) where no event occured. Thus the IRQ will
> >> not be cleared, retriggering the ISR.
> >> Fix that (like done before) by only set the PIOC GPIO chip to the IRQ chip
> >> and walk the list in the irq handler.
> >>
> >> Signed-off-by: Alexander Stein <alexanders83@web.de>
> >> ---
> >> Changes in v2:
> >> * Fix git SHA1 in commit message (used local one)
> >> * Switch to the next gpio_chip when walking the list
> > 
> > This v2 patch applied for next.
> 
> Linus,
> 
> I do not see this patch in your "for-next" branch nor in linux-next. Did
> I miss something?
> 

I don't see it either, I would prefer that we don't miss it for 3.16,
can you check ?

Thanks,

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-05-21 17:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-23 21:40 [PATCH] pinctrl/at91: Fix lockup when IRQ on PIOC and PIOD occurs Alexander Stein
2014-04-23 22:34 ` Alexander Stein
2014-04-24 17:55 ` [PATCH v2] " Alexander Stein
2014-04-25  9:18   ` Linus Walleij
2014-05-09 10:23     ` Nicolas Ferre
2014-05-21 17:15       ` Alexandre Belloni [this message]
2014-05-27  9:13       ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140521171532.GH3582@piout.net \
    --to=alexandre.belloni@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.