From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] at91: DT for 3.16 #2
Date: Wed, 21 May 2014 23:42:55 +0200 [thread overview]
Message-ID: <20140521214255.GL3582@piout.net> (raw)
In-Reply-To: <20140521211105.GD24341@quad.lixom.net>
Hi,
On 21/05/2014 at 14:11:05 -0700, Olof Johansson wrote :
> > This directory is flat, the board names are chosen by companies and
> > people that we do not control, a user tend to like finding his preferred
> > board dtb file unchanged from a kernel revision to another...
> > Well all this lead me to think that we don't have to loose too much time
> > thinking about a new strict convention for this file naming or changing
> > all this once again just for the sake of it.
> >
> > Other SoC maintainers beautifully designed from the beginning the naming
> > scheme of their DT files, fine. AT91 did not and forgive me but when
> > opening arch/arm/boot/dts/Makefile file and seeing some file names, I'm
> > not ashamed. Moreover, now that I said to everybody since 3.10 to prefix
> > their *board* name with "at91-", I have to say something else, I don't
> > think it is worth it.
>
> I don't agree with everything above, but it's not worth arguing for the
> sake of arguing. :) I think we can tweak what you're doing now and get
> things to work well by merging new dts files with at91-<soc>-board.dts
> as the name. As mentioned, don't worry about the existing files. This
> shouldn't be a significiant change to what you've been telling people
> since 3.10 to cause much confusion.
>
I'm not sure we should keep the at91 prefix. The sama5d3 series is not
at91.
I would suggest using <soc>-<vendor>-<board> in the future, like what is
done for mvebu, berlin and some omap3 and freescale boards. I would
however make an exception for the evaluation kits and keep the current
"<soc>ek" name (else we would get sama5d3-atmel-sama5d3ek).
I also got confused by the at91- prefix when looking for a few dts files
but I think it is too late to rename now or maybe we could do it all at
once for a long term release (provided we know which one it will be).
For reference, the list of files that would need renaming:
animeo_ip.dts
at91-ariag25.dts
at91-cosino.dtsi
at91-cosino_mega2560.dts
at91-foxg20.dts
at91-qil_a9260.dts
ethernut5.dts
ge863-pro3.dtsi
kizbox.dts
mpa1600.dts
pm9g45.dts
tny_a9260.dts
tny_a9263.dts
tny_a9g20.dts
usb_a9260.dts
usb_a9263.dts
usb_a9g20_common.dtsi
aks-cdu.dts
evk-pro3.dts
at91-sama5d3_xplained.dts
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Olof Johansson <olof@lixom.net>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
Boris BREZILLON <boris.brezillon@free-electrons.com>,
Arnd Bergmann <arnd@arndb.de>,
arm@kernel.org, Linux Kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
Wenyou Yang <wenyou.yang@atmel.com>,
Ludovic Desroches <ludovic.desroches@atmel.com>
Subject: Re: [GIT PULL] at91: DT for 3.16 #2
Date: Wed, 21 May 2014 23:42:55 +0200 [thread overview]
Message-ID: <20140521214255.GL3582@piout.net> (raw)
In-Reply-To: <20140521211105.GD24341@quad.lixom.net>
Hi,
On 21/05/2014 at 14:11:05 -0700, Olof Johansson wrote :
> > This directory is flat, the board names are chosen by companies and
> > people that we do not control, a user tend to like finding his preferred
> > board dtb file unchanged from a kernel revision to another...
> > Well all this lead me to think that we don't have to loose too much time
> > thinking about a new strict convention for this file naming or changing
> > all this once again just for the sake of it.
> >
> > Other SoC maintainers beautifully designed from the beginning the naming
> > scheme of their DT files, fine. AT91 did not and forgive me but when
> > opening arch/arm/boot/dts/Makefile file and seeing some file names, I'm
> > not ashamed. Moreover, now that I said to everybody since 3.10 to prefix
> > their *board* name with "at91-", I have to say something else, I don't
> > think it is worth it.
>
> I don't agree with everything above, but it's not worth arguing for the
> sake of arguing. :) I think we can tweak what you're doing now and get
> things to work well by merging new dts files with at91-<soc>-board.dts
> as the name. As mentioned, don't worry about the existing files. This
> shouldn't be a significiant change to what you've been telling people
> since 3.10 to cause much confusion.
>
I'm not sure we should keep the at91 prefix. The sama5d3 series is not
at91.
I would suggest using <soc>-<vendor>-<board> in the future, like what is
done for mvebu, berlin and some omap3 and freescale boards. I would
however make an exception for the evaluation kits and keep the current
"<soc>ek" name (else we would get sama5d3-atmel-sama5d3ek).
I also got confused by the at91- prefix when looking for a few dts files
but I think it is too late to rename now or maybe we could do it all at
once for a long term release (provided we know which one it will be).
For reference, the list of files that would need renaming:
animeo_ip.dts
at91-ariag25.dts
at91-cosino.dtsi
at91-cosino_mega2560.dts
at91-foxg20.dts
at91-qil_a9260.dts
ethernut5.dts
ge863-pro3.dtsi
kizbox.dts
mpa1600.dts
pm9g45.dts
tny_a9260.dts
tny_a9263.dts
tny_a9g20.dts
usb_a9260.dts
usb_a9263.dts
usb_a9g20_common.dtsi
aks-cdu.dts
evk-pro3.dts
at91-sama5d3_xplained.dts
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-05-21 21:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 9:19 [GIT PULL] at91: DT for 3.16 #2 Nicolas Ferre
2014-05-14 9:19 ` Nicolas Ferre
2014-05-20 5:50 ` Olof Johansson
2014-05-20 5:50 ` Olof Johansson
2014-05-20 15:19 ` Nicolas Ferre
2014-05-20 15:19 ` Nicolas Ferre
2014-05-20 16:47 ` Olof Johansson
2014-05-20 16:47 ` Olof Johansson
2014-05-21 10:17 ` Nicolas Ferre
2014-05-21 10:17 ` Nicolas Ferre
2014-05-21 21:11 ` Olof Johansson
2014-05-21 21:11 ` Olof Johansson
2014-05-21 21:39 ` Olof Johansson
2014-05-21 21:39 ` Olof Johansson
2014-05-21 21:42 ` Alexandre Belloni [this message]
2014-05-21 21:42 ` Alexandre Belloni
2014-05-21 21:51 ` Olof Johansson
2014-05-21 21:51 ` Olof Johansson
2014-05-22 8:48 ` Nicolas Ferre
2014-05-22 8:48 ` Nicolas Ferre
2014-05-20 17:13 ` Jean-Christophe PLAGNIOL-VILLARD
2014-05-20 17:13 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140521214255.GL3582@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.