All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Yang <weiyang@linux.vnet.ibm.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Yinghai Lu <yinghai@kernel.org>,
	talal@mellanox.com, Wei Yang <weiyang@linux.vnet.ibm.com>,
	Gavin Shan <shangw@linux.vnet.ibm.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	amirv@mellanox.com, eugenia@mellanox.com,
	Guo Chao <yan@linux.vnet.ibm.com>,
	linux-pci@vger.kernel.org, Or Gerlitz <ogerlitz@mellanox.com>,
	Jack Morgenstein <jackm@dev.mellanox.co.il>
Subject: Re: [PATCH v10 2/4] PCI: Change pbus_size_mem() return values to be more conventional
Date: Thu, 22 May 2014 16:20:33 +0800	[thread overview]
Message-ID: <20140522082033.GA13988@richard> (raw)
In-Reply-To: <20140520034558.11972.74795.stgit@bhelgaas-glaptop.roam.corp.google.com>

On Mon, May 19, 2014 at 09:45:58PM -0600, Bjorn Helgaas wrote:
>pbus_size_mem() previously returned 0 for failure and 1 for success.
>Change it to return -ENOSPC for failure and 0 for success.
>
>No functional change.
>
>Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>---
> drivers/pci/setup-bus.c |   35 +++++++++++++++++++++--------------
> 1 file changed, 21 insertions(+), 14 deletions(-)
>
>diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
>index 589f2261ab0e..caa07fe6a23a 100644
>--- a/drivers/pci/setup-bus.c
>+++ b/drivers/pci/setup-bus.c
>@@ -915,6 +915,10 @@ static inline resource_size_t calculate_mem_align(resource_size_t *aligns,
>  *
>  * Calculate the size of the bus and minimal alignment which
>  * guarantees that all child resources fit in this size.
>+ *
>+ * Returns -ENOSPC 0 if there's no available bus resource of the desired type.
                    ^^^
One small question, the 0 here means?


-- 
Richard Yang
Help you, Help me


  reply	other threads:[~2014-05-22  8:20 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAE9FiQXzRQ9S0mwwb58R2icBTtHHJ6NMVFMaxEgtVNP9mZVjZw@mail.gmail.com>
2014-03-07 20:08 ` [PATCH v7] PCI: Try best to allocate pref mmio 64bit above 4g Yinghai Lu
2014-04-04 22:43   ` Bjorn Helgaas
2014-04-08  2:57     ` Guo Chao
2014-04-08  7:18       ` Or Gerlitz
2014-04-08  7:41         ` Wei Yang
2014-04-08  7:55           ` Or Gerlitz
2014-04-08  8:22             ` Guo Chao
2014-04-08 15:02       ` Bjorn Helgaas
2014-04-09  7:52         ` Guo Chao
2014-04-10 17:26           ` Bjorn Helgaas
2014-04-10 21:23             ` Benjamin Herrenschmidt
2014-04-15 11:54             ` Guo Chao
2014-04-16  0:09               ` Bjorn Helgaas
2014-04-16  2:29                 ` Yinghai Lu
2014-04-16 17:06                   ` Bjorn Helgaas
2014-04-17  3:30                     ` Yinghai Lu
2014-04-16  4:16                 ` Yinghai Lu
2014-04-16 17:10                   ` Bjorn Helgaas
2014-04-16  6:30                 ` Benjamin Herrenschmidt
2014-04-16  6:33                   ` Benjamin Herrenschmidt
2014-04-16 17:15                     ` Bjorn Helgaas
2014-04-16 22:11   ` Bjorn Helgaas
2014-04-17  4:20     ` Yinghai Lu
2014-04-17 16:35       ` Yinghai Lu
2014-04-17  4:23 ` [PATCH v8] " Yinghai Lu
2014-04-17 16:40 ` [PATCH v9] " Yinghai Lu
2014-05-20  3:45   ` [PATCH v10 0/4] PCI: Restrict 64-bit prefetchable bridge windows to 64-bit resources Bjorn Helgaas
2014-05-20  3:45     ` [PATCH v10 1/4] " Bjorn Helgaas
2014-05-20  3:45     ` [PATCH v10 2/4] PCI: Change pbus_size_mem() return values to be more conventional Bjorn Helgaas
2014-05-22  8:20       ` Wei Yang [this message]
2014-05-22 16:59         ` Bjorn Helgaas
2014-05-20  3:46     ` [PATCH v10 3/4] PCI: Simplify __pci_assign_resource() coding style Bjorn Helgaas
2014-05-20  3:46     ` [PATCH v10 4/4] PCI: Add resource allocation comments Bjorn Helgaas
2014-05-21  3:31     ` [PATCH v10 0/4] PCI: Restrict 64-bit prefetchable bridge windows to 64-bit resources Wei Yang
2014-05-21  4:36       ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140522082033.GA13988@richard \
    --to=weiyang@linux.vnet.ibm.com \
    --cc=amirv@mellanox.com \
    --cc=benh@kernel.crashing.org \
    --cc=bhelgaas@google.com \
    --cc=eugenia@mellanox.com \
    --cc=jackm@dev.mellanox.co.il \
    --cc=linux-pci@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=shangw@linux.vnet.ibm.com \
    --cc=talal@mellanox.com \
    --cc=yan@linux.vnet.ibm.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.