From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH V6 10/11] ACPI: use platform bus as the default bus for _HID enumeration Date: Thu, 22 May 2014 12:58:23 +0300 Message-ID: <20140522095823.GE1651@lahna.fi.intel.com> References: <1400136256-2218-1-git-send-email-rui.zhang@intel.com> <1400136256-2218-11-git-send-email-rui.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga01.intel.com ([192.55.52.88]:9378 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752371AbaEVJ6c (ORCPT ); Thu, 22 May 2014 05:58:32 -0400 Content-Disposition: inline In-Reply-To: <1400136256-2218-11-git-send-email-rui.zhang@intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Zhang Rui Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, bhelgaas@google.com, matthew.garrett@nebula.com, rafael.j.wysocki@intel.com, dmitry.torokhov@gmail.com On Thu, May 15, 2014 at 02:44:15PM +0800, Zhang Rui wrote: > +static void acpi_do_default_enumeration(struct acpi_device *device) > +{ > + /* > + * Do not do enumeration for device object that has been/will be > + * enumerated by its parent. > + */ > + if (device->parent && device->parent->flags.is_master_device) > + return; > + > + /* Do not do enumeration for device object with scan handler attached */ > + if (device->handler) > + return; > + > + /* Do not do enumeration for device object w/o platform_id */ > + if (!device->pnp.type.platform_id) > + return; > + > + acpi_create_platform_device(device, NULL); > +} > + > + You have an extra empty line here.