Re: [PATCH 2/7 v3] trace, AER: Move trace into unified interface

[Borislav Petkov <bp@alien8.de>]

On Wed, May 21, 2014 at 08:03:48PM -0400, Chen, Gong wrote:
> On Wed, May 21, 2014 at 12:19:03PM +0200, Borislav Petkov wrote:
> > >  drivers/pci/pcie/aer/Kconfig           |  1 +
> > >  drivers/pci/pcie/aer/aerdrv_errprint.c |  4 +-
> > >  include/ras/ras_event.h                | 64 ++++++++++++++++++++++++++++
> > >  include/trace/events/ras.h             | 77 ----------------------------------
> > 
> > Ok, I don't understand: all the rest of the kernel holds tracepoints in
> > include/trace/events/. Why are you moving this at all?
> > 
> > Why can't the new extlog tracepoint in patch 5 be added to
> > include/trace/events/ras.h too?
> > 
> OMG. Again? Long time ago Mauro highly recommended me not putting new
> tracepoints under include/trace/events/ras.h, on the contrary, it shoud
> be put to include/ras/ras_event.h. But now the same story plays
> again. :-(

Hey Steve, can you help us out please? What is the rationale about
tracepoints and their place? Do we put them in include/trace/events/ or
do we put there only generic enough ones or do we define our own include
path, i.e., include/ras/ras_event.h for example, what is it?

Thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--