From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/panel: add support for AUO B133XTN01 panel Date: Thu, 22 May 2014 13:02:44 +0200 Message-ID: <20140522110243.GB11613@ulmo> References: <1400629008-31646-1-git-send-email-marcheu@chromium.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1594045906==" Return-path: Received: from mail-ee0-f46.google.com (mail-ee0-f46.google.com [74.125.83.46]) by gabe.freedesktop.org (Postfix) with ESMTP id 0F66A89DE5 for ; Thu, 22 May 2014 04:05:04 -0700 (PDT) Received: by mail-ee0-f46.google.com with SMTP id t10so2515473eei.19 for ; Thu, 22 May 2014 04:05:04 -0700 (PDT) In-Reply-To: <1400629008-31646-1-git-send-email-marcheu@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?utf-8?B?U3TDqXBoYW5l?= Marchesin Cc: treding@nvidia.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1594045906== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="nVMJ2NtxeReIH9PS" Content-Disposition: inline --nVMJ2NtxeReIH9PS Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 20, 2014 at 04:36:48PM -0700, St=C3=A9phane Marchesin wrote: > This panel is used by my tegra board and supported by the simple-panel > driver. One thing I like to have is some indication in the commit message about which board this panel is used on. Of course if you can't disclose that yet I'll still take the patch, but perhaps you can be a little more specific than "my Tegra board". There also seem to be different variants of this panel. I've come across datasheets for B133XTN01.0 and B133XTN01.2. The 1.0 seems to be native LVDS whereas it looks as if the 1.2 comes with an additional module to connect it to eDP. Which one is it that you use? I guess independent of the specific model the timings will still work, but device tree mandates that the compatible for the most specific model be used. Perhaps this panel should be: compatible =3D "auo,b133xtn01.2", "auo,b133xtn01", "simple-panel"; That would allow the panel-simple driver to match on "auo,b133xtn01" and pick up the timing that presumably works for both. One other nit below: > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel= /panel-simple.c [...] > +static const struct panel_desc auo_b133xtn01 =3D { > + .modes =3D &auo_b133xtn01_mode, > + .num_modes =3D 1, > + .size =3D { > + .width =3D 293, > + .height =3D 164, According to the datasheet I found this is 164.97 mm, in which case I think it may be better to round up to get a more accurate value of the DPI. Thierry --nVMJ2NtxeReIH9PS Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTfdlTAAoJEN0jrNd/PrOh6NkQAJlU9eL1v/fc2HgdJwXvgPPc y63u38qaPqN7Wyxlec8aAmSQ/X50My3q4OZtiwTJkwbI4JQuD+CTyVY6zEveUZOu MIbKWkP8q4kQeeKHl1itSIT6l8E9kalSTtjhvvR9nMu8PQHKhDafBnm3MHJKzDap lXd6RUqnPvwzub/i9ru86wPETIhC4ogS53LwEqU4CWPM3bwCSzAoejz+7+Zg5752 z2saIiknNK31Dt+BcIlwW/27PMYCZSWy28rjoeIPQQdq2DtFvKD+QiftyPpgKLFj 3kok71MF+jLqLMy54hsoygXKawkJpWaMLF2CkY5gJfoEKlNGNT1CFIezSTvPcUUW zL7yPC6Nyq0ORneLxjhCAH6IsC8K/oCRI+OGDfEPjyqYfxp+HDXvETyVAu6GAwaO VhrDESeBWoOfXiLDL63i+K6zS8hvJHWD4Ba4HJEX8fcGWtTGLoeEloYGUtlJL3X0 QfZ63qUoqfV/kekta7UTO9U5SZaYvommQQSzjurZJFauJf2FNBmpBL3ikRa3pP8y EY/SWDDDo5qYPqXCI3WUspT17l3LdjQejiQpLl24Fvzpi/j6/rqtUGpfA5Kgm11E //TCfKLvsKWcjGuylegStShKWKdK+1hUV1MO7okdiX0F+eK50keybza6PhJTW0Sn UZ9MDRx5UT8MwQ1cW0Nx =jOIm -----END PGP SIGNATURE----- --nVMJ2NtxeReIH9PS-- --===============1594045906== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1594045906==--