All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Taras Kondratiuk <taras.kondratiuk@linaro.org>
Cc: kexec@lists.infradead.org, Lubomir Rintel <lkundrak@v3.sk>,
	Simon Horman <horms@verge.net.au>, Joe Perches <joe@perches.com>,
	Dave Young <dyoung@redhat.com>, WANG Chao <chaowang@redhat.com>
Subject: Re: [PATCH v2] vmcore-dmesg: Understand >= v3.11-rc4 dmesg
Date: Thu, 22 May 2014 09:51:01 -0400	[thread overview]
Message-ID: <20140522135101.GD13647@redhat.com> (raw)
In-Reply-To: <52728878.2080302@linaro.org>

On Thu, Oct 31, 2013 at 09:42:32AM -0700, Taras Kondratiuk wrote:

[..]

This patch has not gone it for quite some time and vmcore-dmesg continues
to fail for me with upstream kernels. So it is time to do something
about it.

> I have concerns about this patch.
> There were a lot of hardcoded lenght values in the original code.

One can easily fix that by using strlen().

> Now there are twice as much and we need to keep adding hardcoded
> values if any additional parameter should be read of renamed.
> 
> Please eveluate this patch [1]. It should remove both:
> hardcoded values and duplicated reading for two buffer names.

I don't like excessive usage of macros. And in your patch you are
using nested marcros.

While it might make look code smaller, readability of code becomes
a problem. 

So I personally like simpler approach. And please use strlen() for
fixing the hardcoding of length issue.

Thanks
Vivek

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

      parent reply	other threads:[~2014-05-22 13:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-18 12:21 [RESEND PATCH] vmcore-dmesg: Understand >= v3.11-rc4 dmesg Lubomir Rintel
2013-09-19 14:38 ` Dave Young
2013-09-19 14:49   ` [PATCH v2] " Lubomir Rintel
2013-09-20  1:50     ` Dave Young
2013-09-20  1:55       ` Joe Perches
2013-09-20  7:40         ` Dave Young
2013-09-23 17:03     ` Vivek Goyal
2013-10-30  3:12     ` WANG Chao
2013-10-30 17:06       ` Lubomir Rintel
2013-10-31  0:34         ` Taras Kondratiuk
2013-10-31  5:38         ` WANG Chao
2013-10-31  6:18           ` WANG Chao
2013-10-31  6:20           ` Simon Horman
2013-10-31 16:42             ` Taras Kondratiuk
2013-11-01  0:32               ` Simon Horman
2014-05-22 13:51               ` Vivek Goyal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140522135101.GD13647@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=chaowang@redhat.com \
    --cc=dyoung@redhat.com \
    --cc=horms@verge.net.au \
    --cc=joe@perches.com \
    --cc=kexec@lists.infradead.org \
    --cc=lkundrak@v3.sk \
    --cc=taras.kondratiuk@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.