From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: sunxi: fix pin numbers passed to register offset helpers
Date: Fri, 23 May 2014 09:25:38 +0200 [thread overview]
Message-ID: <20140523072538.GG27329@lukather> (raw)
In-Reply-To: <CACRpkdb14bv83yu87aps6QhO-_Map87akt9Uc04VSr2a=ZzD3w@mail.gmail.com>
On Fri, May 23, 2014 at 12:38:09AM +0200, Linus Walleij wrote:
> On Thu, May 22, 2014 at 5:20 PM, Chen-Yu Tsai <wens@csie.org> wrote:
>
> > The pin numbers passed to sunxi_*_reg helpers to get the correct
> > registers should be the pin offset for the PIO block, not the
> > absolute number we use that is based on the alphanumeric labels
> > Allwinner uses.
> >
> > This patch subtracts .pin_base from the pin number passed to these
> > functions, so the driver accesses the correct registers.
> >
> > Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>
> Maxime, can I have your ACK on this patch, too?
You have it!
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140523/63b4a976/attachment.sig>
next prev parent reply other threads:[~2014-05-23 7:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 15:20 [PATCH] pinctrl: sunxi: fix pin numbers passed to register offset helpers Chen-Yu Tsai
2014-05-22 15:37 ` Boris BREZILLON
2014-05-22 22:38 ` Linus Walleij
2014-05-23 7:25 ` Maxime Ripard [this message]
2014-05-27 9:27 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140523072538.GG27329@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.