All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Masaru Nomura <massa.nomura@gmail.com>
Cc: andreas.dilger@intel.com, green@linuxhacker.ru,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] staging: lustre: lnet: klnds: Fix coding style in socklnd.c
Date: Fri, 23 May 2014 12:07:57 +0000	[thread overview]
Message-ID: <20140523120757.GA6540@kroah.com> (raw)
In-Reply-To: <1400540603-12039-1-git-send-email-massa.nomura@gmail.com>

On Tue, May 20, 2014 at 12:03:23AM +0100, Masaru Nomura wrote:
> Remove prohibited space between function name and
> open parenthesis to meet kernel coding style.
> Also fix indenting due to changes to keep readability.
> 
> I undid modifications to memset(...) which I made in
> previous patches as it could be removed based on
> the fact LIBCFS_ALLOC is executed before memset.
> With this, others can notice warnings against memset
> caused by checkpatch.pl and modify it easily.
> 
> Signed-off-by: Masaru Nomura <massa.nomura@gmail.com>
> ---
>  .../staging/lustre/lnet/klnds/socklnd/socklnd.c    |  238 ++++++++++----------
>  1 file changed, 119 insertions(+), 119 deletions(-)

This patch doesn't apply against my tree anymore.  Can you please
refresh it and resend?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Masaru Nomura <massa.nomura@gmail.com>
Cc: andreas.dilger@intel.com, green@linuxhacker.ru,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] staging: lustre: lnet: klnds: Fix coding style in socklnd.c
Date: Fri, 23 May 2014 21:07:57 +0900	[thread overview]
Message-ID: <20140523120757.GA6540@kroah.com> (raw)
In-Reply-To: <1400540603-12039-1-git-send-email-massa.nomura@gmail.com>

On Tue, May 20, 2014 at 12:03:23AM +0100, Masaru Nomura wrote:
> Remove prohibited space between function name and
> open parenthesis to meet kernel coding style.
> Also fix indenting due to changes to keep readability.
> 
> I undid modifications to memset(...) which I made in
> previous patches as it could be removed based on
> the fact LIBCFS_ALLOC is executed before memset.
> With this, others can notice warnings against memset
> caused by checkpatch.pl and modify it easily.
> 
> Signed-off-by: Masaru Nomura <massa.nomura@gmail.com>
> ---
>  .../staging/lustre/lnet/klnds/socklnd/socklnd.c    |  238 ++++++++++----------
>  1 file changed, 119 insertions(+), 119 deletions(-)

This patch doesn't apply against my tree anymore.  Can you please
refresh it and resend?

thanks,

greg k-h

  reply	other threads:[~2014-05-23 12:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-19 23:03 [PATCH v2] staging: lustre: lnet: klnds: Fix coding style in socklnd.c Masaru Nomura
2014-05-19 23:03 ` Masaru Nomura
2014-05-23 12:07 ` Greg KH [this message]
2014-05-23 12:07   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140523120757.GA6540@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=green@linuxhacker.ru \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=massa.nomura@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.