All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: sunxi: Enable the pinctrl Kconfig options by default
Date: Fri, 23 May 2014 12:19:34 +0200	[thread overview]
Message-ID: <201405231219.35061.arnd@arndb.de> (raw)
In-Reply-To: <CACRpkdb2gzpftp3PWkr40v1CZm2J=SmnY9Mb=5S-AJr+YXgkNg@mail.gmail.com>

On Friday 16 May 2014, Linus Walleij wrote:
> On Tue, May 13, 2014 at 5:23 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> 
> > Enable the freshly introduced Kconfig options whenever their matching
> > architecture is enabled.
> >
> > Since the Kconfig symbols for these machines are going through a different
> > tree, keep PINCTRL_SUNXI around for the moment to avoid breaking the defconfig.
> > It should be removed eventually.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> 
> OK patch applied.


I stumbled over this build error now:

/git/arm-soc/drivers/phy/phy-sun4i-usb.c: In function 'sun4i_usb_phy_probe':
/git/arm-soc/drivers/phy/phy-sun4i-usb.c:282:3: error: implicit declaration of function 'devm_reset_control_get' [-Werror=implicit-function-declaration]
   phy->reset = devm_reset_control_get(dev, name);
   ^
/git/arm-soc/drivers/phy/phy-sun4i-usb.c:282:14: warning: assignment makes pointer from integer without a cast [enabled by default]
   phy->reset = devm_reset_control_get(dev, name);
              ^
cc1: some warnings being treated as errors
make[4]: *** [drivers/phy/phy-sun4i-usb.o] Error 1
/git/arm-soc/drivers/pinctrl/sunxi/pinctrl-sun6i-a31-r.c: In function 'sun6i_a31_r_pinctrl_probe':
/git/arm-soc/drivers/pinctrl/sunxi/pinctrl-sun6i-a31-r.c:103:2: error: implicit declaration of function 'devm_reset_control_get' [-Werror=implicit-function-declaration]
  rstc = devm_reset_control_get(&pdev->dev, NULL);
  ^
/git/arm-soc/drivers/pinctrl/sunxi/pinctrl-sun6i-a31-r.c:103:7: warning: assignment makes pointer from integer without a cast [enabled by default]
  rstc = devm_reset_control_get(&pdev->dev, NULL);
       ^
cc1: some warnings being treated as errors


It seems both the phy and the pinctrl driver actually depend on the
reset controller framework, but this is not reflected in Kconfig.

I guess these should either use devm_reset_control_get_optional
or have 'depends on RESET_CONTROLLER' in Kconfig.

	Arnd

  reply	other threads:[~2014-05-23 10:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-13 15:23 [PATCH] pinctrl: sunxi: Enable the pinctrl Kconfig options by default Maxime Ripard
2014-05-16 13:40 ` Linus Walleij
2014-05-23 10:19   ` Arnd Bergmann [this message]
2014-05-23 18:45     ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201405231219.35061.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.